Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 20 Mar 2020 17:24:26 -0600
From:   Jonathan Corbet <corbet@lwn.net>
To:     Wang Wenhu <wenhu.wang@vivo.com>
Cc:     Harry Wei <harryxiyou@gmail.com>,
        Alex Shi <alex.shi@linux.alibaba.com>,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel@vivo.com
Subject: Re: [PATCH v2,RESEND] doc: zh_CN: fix style problems for
 io_ordering.txt
Message-ID: <20200320172426.121d881d@lwn.net>
In-Reply-To: <20200315060857.82880-1-wenhu.wang@vivo.com>
References: <20200315060857.82880-1-wenhu.wang@vivo.com>
Organization: LWN.net
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, 14 Mar 2020 23:08:55 -0700
Wang Wenhu <wenhu.wang@vivo.com> wrote:

> Problems exist in the Chinese translation of io_ordering.txt.
> Partly for the difference between Chinese and English character
> encoding format, and the others are of the failure to comply
> with the ReST markups.

So I feel like I'm missing something here...

> Signed-off-by: Wang Wenhu <wenhu.wang@vivo.com>
> ---
> v2: resend for the failure of delivering.
> 
>  .../translations/zh_CN/io_ordering.txt        | 72 ++++++++++++-------
>  1 file changed, 46 insertions(+), 26 deletions(-)
> 
> diff --git a/Documentation/translations/zh_CN/io_ordering.txt b/Documentation/translations/zh_CN/io_ordering.txt
> index 1f8127bdd415..080ed2911db0 100644
> --- a/Documentation/translations/zh_CN/io_ordering.txt
> +++ b/Documentation/translations/zh_CN/io_ordering.txt
> @@ -29,39 +29,59 @@ Documentation/io_ordering.txt 的中文翻译
>  这也可以保证后面的写操作只在前面的写操作之后到达设备（这非常类似于内存
>  屏障操作，mb()，不过仅适用于I/O）。
>  
> +A more concrete example from a hypothetical device driver::
> +
> +		...
> +	CPU A:  spin_lock_irqsave(&dev_lock, flags)
> +	CPU A:  val = readl(my_status);
> +	CPU A:  ...
> +	CPU A:  writel(newval, ring_ptr);
> +	CPU A:  spin_unlock_irqrestore(&dev_lock, flags)
> +		...
> +	CPU B:  spin_lock_irqsave(&dev_lock, flags)
> +	CPU B:  val = readl(my_status);
> +	CPU B:  ...
> +	CPU B:  writel(newval2, ring_ptr);
> +	CPU B:  spin_unlock_irqrestore(&dev_lock, flags)
> +		...
> +
> +
>  假设一个设备驱动程的具体例子：
> +::
>  
> +		...
> +	CPU A:  spin_lock_irqsave(&dev_lock, flags)
> +	CPU A:  val = readl(my_status);
> +	CPU A:  ...
> +	CPU A:  writel(newval, ring_ptr);
> +	CPU A:  spin_unlock_irqrestore(&dev_lock, flags)
> +		...
> +	CPU B:  spin_lock_irqsave(&dev_lock, flags)
> +	CPU B:  val = readl(my_status);
> +	CPU B:  ...
> +	CPU B:  writel(newval2, ring_ptr);
> +	CPU B:  spin_unlock_irqrestore(&dev_lock, flags)

It sure looks like you're adding the same text twice here...?

Thanks,

jon