Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1253284ybb; Fri, 20 Mar 2020 16:37:43 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtI7nx3UalLmI544LZ8YUijJjYHbnfagAOakfQUvNmExpnle7w9k/mRU4ht65FLku5LyvKL X-Received: by 2002:a05:6830:23b6:: with SMTP id m22mr5129036ots.225.1584747462932; Fri, 20 Mar 2020 16:37:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584747462; cv=none; d=google.com; s=arc-20160816; b=ey7LPXh/3gfgfOen9m9RErqXvk6VfcwlGUrJMuabTfNpgBfXh1uIHV0Hq+nPTedyQw puIIOC+LKNsL2AQdBF92h9J84N97udVHstG4C9lsAYK+zPBoIdj1wcEJeQAtTjV+wxlm mfU3/J879E5KODE1xTtPIc+ThI3DTOR3cgjQQOMQhXYecb/+3K19DhhOYkp+qW2PMBpM lxem+3UOLI+xA54rA+vpSzF/5HKzSPzcSfjom4vqKJRz6HMUErMuE9ObgL54/9nVKT+3 a9F8/wesKRw1MDLu/OvkFE4AobvwXPt0ViuEd1t4EGc82SEOEobMjdgDMtmonOLity8w dOtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=r56c2sC6zamlywNB9189icYDyAGKVdxKEKYyEkkrtbs=; b=mV81TP5/CyLzqkLwMi1Obfisxkjqw65FoLLcAE3ZBwv6auouMCpJ1izzXOLNsysBhk 2fTgja1BNYvR1lOVg4dkU2eB83h1qbOeDl7ULk6pB9/nyCku9bjwM9gzhbYff8sgt6PY rhl+iXdCXvnnLxgcPLJ+XI5VZzWfqbowgD80V0YHuNUP0xBN2+wsD1L+7lAlljUFJ1oR IdN7vgZ0duAmshXSHJgzglnxgrv1jArSR0tMOhkqYmk2mBnIBmwNpcY6VJ9y5yTzYyY7 qi6XOVu3SOKzEpFgUIsbhBPgtjwL982P6gO9fJTB3tRSsjSqkHJK/2G4ssaJsRWqrVE5 Ds9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=jIglHsdB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h59si3789336oth.233.2020.03.20.16.37.30; Fri, 20 Mar 2020 16:37:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=jIglHsdB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727763AbgCTXgj (ORCPT + 99 others); Fri, 20 Mar 2020 19:36:39 -0400 Received: from mail-io1-f67.google.com ([209.85.166.67]:38976 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727631AbgCTXgh (ORCPT ); Fri, 20 Mar 2020 19:36:37 -0400 Received: by mail-io1-f67.google.com with SMTP id c19so7865543ioo.6; Fri, 20 Mar 2020 16:36:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=r56c2sC6zamlywNB9189icYDyAGKVdxKEKYyEkkrtbs=; b=jIglHsdBBqGfP+iZRD+xmqhg6u0oes4iqVrlOxhxfrU1/HvYH5tqBY70q8K1GaW7F7 QU2tfM/SHKVZDjBBz0r9YusVGDwACXLU1bCYVNAGidoXju78eb+xAUbeE2VgD2zpqIfb yBDLxS6nFFsQsbfOUo83L8DO4uPPdW9djOvDu0oi1szuCKH2KlxqCk+jCRWDJqmwxcvr 78m1MAonXVES7tNbLechb9RFdd55Dh00aS2rycxffXWNAbZDp//pD7nCLeo3IJPjn+wk rSaw8qk9RS+22pcZEz+ee24ZRKw6DO0N6p+m1nqrdzOFbGfCRk938uF18LUKYL9jcdpz dnoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=r56c2sC6zamlywNB9189icYDyAGKVdxKEKYyEkkrtbs=; b=o/m21ztVyO/AkF/nmBdH7SFF+R8pmzEA7CdUcKJ/43h5bjG3MAQShq2endrTJ1u/XR OGzryo7e/OlMnVKbyzbFgKWkkoqHYZseE7Dig0OV6grCutaP2jmifnHwe5Z4sHs+T9d+ mAWg63dJxlSw3kboStnLrsvKKdwmcSC05dQbiVgM8i9v3ZfZtUL0Lr0KadcEbWgn/+6U vwAFHJ4XTUfEbbAy4Dr0tX4tohO/QIaRKVZIoIulzmw72nTRmFP9DrucElyJ73ls3Irn YcpMTyih/aDU2jCv48AiyOj/H0Md8YTaFQpQzAmL2IVYwiQwBXImB1qVMWqQz1uW4ODU LZJg== X-Gm-Message-State: ANhLgQ2vgZ9gIaXyXga+IIomuyw4pu/r9QIP4qadXaku96dcADA7XXOz SfT189UBAv221mcT/4RZoFO/X1g2dhtR6YZRw7U= X-Received: by 2002:a02:1683:: with SMTP id a125mr2499634jaa.61.1584747396297; Fri, 20 Mar 2020 16:36:36 -0700 (PDT) MIME-Version: 1.0 References: <20200320110959.2114-1-hqjagain@gmail.com> <2dc8673f-a46d-1438-95a8-cfb455bbea57@gmail.com> In-Reply-To: <2dc8673f-a46d-1438-95a8-cfb455bbea57@gmail.com> From: Qiujun Huang Date: Sat, 21 Mar 2020 07:36:24 +0800 Message-ID: Subject: Re: [PATCH v3] sctp: fix refcount bug in sctp_wfree To: Eric Dumazet Cc: Marcelo Ricardo Leitner , "David S. Miller" , vyasevich@gmail.com, nhorman@tuxdriver.com, Jakub Kicinski , linux-sctp@vger.kernel.org, netdev , LKML , anenbupt@gmail.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 21, 2020 at 1:10 AM Eric Dumazet wrote: > > > > > This does not really solve the issue. > > Even if the particular syzbot repro is now fine. > > Really, having anything _after_ the sock_wfree(skb) is the bug, since the current thread no longer > own a reference on a socket. I get it, thanks. > > > >