Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1696876ybb; Sat, 21 Mar 2020 04:03:41 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvMp1G34dwgrmqvvXNKSFU4Unyz3kTY82eUG0e2f4SgDNtyIioSszuecJNIuCzXS1mm2IoV X-Received: by 2002:a54:440d:: with SMTP id k13mr10294592oiw.72.1584788621005; Sat, 21 Mar 2020 04:03:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584788620; cv=none; d=google.com; s=arc-20160816; b=pKZQpvSs/QCnNextM8FPQ5IQC7jVlTaCv1iTJtjRApzYsDrpEVu/2yC7PfWD/5t1Oq f+ptyxTecTnykdJWv87JmszK7NAGccLZUTZvccjL51IKByzW7d/K2OxgOybpoD7AkbRp B0fvqYqQlk+S4aVfKgKN/dCiyyCfYgRrfeyNKfFmto+h2whEyYf2nNAQ3ehpbszSgQ81 cic7m892W9OTv7Flu+M1zZ8vvSo6YqgkLEAz3+nEOGeR1xlWvenKss/7nONRDOlFJ7XG /5aN0jx8ysPh5KHliWdYmdpifmClAOd0D8/Eb5FT/GyrSKLhvGNajF2QGli16Imfq8Uk 0btA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=0U1fXVcuNDodjWRJvbc/kbLCHM1x0srjA7fD9oEIs10=; b=sT5JS+joMhzn1SAqL2uPRaLEPUEGrcu2K5jSsUCLa6t92Gwg3sYU9kbBJ/ypQd6obD Jc6LJ0JNZDngvuBP9AzLOH8tYOUgF3iOUweH64rfRaSov+Q2N81Pr9BH/ue4u5txkvdo sR7J1awsFK2N/uw3NMNNpAgbmyJqAiHtIAVpEG/Own0WT73L4asCFFLBfN/g4EPrbL96 Mzq16HCiLqFeHcq88y5QwVYB1v+jqEpdLOFYJEbUuTPfd7ZlIF5Zy5wItpw8qm2s0oEJ +Yz0DeT5u+0M/4fkwmAcXJWaENT/jiUgazmwmpXzglPADaby/mBGyYR5RjrLS+xz/tZW LufQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ZfR5H4Wx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g141si4490537oib.45.2020.03.21.04.03.21; Sat, 21 Mar 2020 04:03:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ZfR5H4Wx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728461AbgCULCP (ORCPT + 99 others); Sat, 21 Mar 2020 07:02:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:37610 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727008AbgCULCP (ORCPT ); Sat, 21 Mar 2020 07:02:15 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AE09120663; Sat, 21 Mar 2020 11:02:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584788534; bh=r5lN5VjYmFqP9Ll27OwvfZvHkuA6f9d2W+KuXcYOUyM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZfR5H4WxwoXnxV9XqAGVXuz1Y5PtvbcNGIEmt7NExb93oi6D2l2H/Mp+MloaMainU Y5bj4HmB6TaGdv32XokbM9Tf7aMUpl9SLaVIlu86mKUK8jzs1AuMwCow9D+2rH7JyP wEKIfEaty8hnpdgtRo12koIe0pDjzioV10tJ3Rns= Date: Sat, 21 Mar 2020 11:02:10 +0000 From: Jonathan Cameron To: Rohit Sarkar Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler Subject: Re: [PATCH] iio: core: Make mlock internal to the iio core Message-ID: <20200321110210.635224c4@archlinux> In-Reply-To: <5e72484b.1c69fb81.53f77.5a16@mx.google.com> References: <5e72484b.1c69fb81.53f77.5a16@mx.google.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 18 Mar 2020 21:41:51 +0530 Rohit Sarkar wrote: > "mlock" should ideally only be used by the iio core. The mlock > implementation may change in the future which means that no driver > should be explicitly using mlock. > > Signed-off-by: Rohit Sarkar Good idea. Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > include/linux/iio/iio.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h > index eed58ed2f368..e975020abaa6 100644 > --- a/include/linux/iio/iio.h > +++ b/include/linux/iio/iio.h > @@ -492,7 +492,7 @@ struct iio_buffer_setup_ops { > * @buffer: [DRIVER] any buffer present > * @buffer_list: [INTERN] list of all buffers currently attached > * @scan_bytes: [INTERN] num bytes captured to be fed to buffer demux > - * @mlock: [DRIVER] lock used to prevent simultaneous device state > + * @mlock: [INTERN] lock used to prevent simultaneous device state > * changes > * @available_scan_masks: [DRIVER] optional array of allowed bitmasks > * @masklength: [INTERN] the length of the mask established from