Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <a7778635620163cb6185192819a56ed44d76d4b0.camel@perches.com>
Subject: Re: [PATCH] drivers: iio: Drop unnecessary explicit casting
From:   Joe Perches <joe@perches.com>
To:     Nishant Malpani <nish.malpani25@gmail.com>, jic23@kernel.org
Cc:     knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Sat, 21 Mar 2020 05:26:52 -0700
In-Reply-To: <20200318100754.25667-1-nish.malpani25@gmail.com>
References: <20200318100754.25667-1-nish.malpani25@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.34.1-2 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 2020-03-18 at 15:37 +0530, Nishant Malpani wrote:
> Provide correct specifiers while printing error logs to discard the use
> of unnecessary explicit casting.
[]
> diff --git a/drivers/iio/accel/kxsd9-i2c.c b/drivers/iio/accel/kxsd9-i2c.c
[]
> @@ -21,8 +21,8 @@ static int kxsd9_i2c_probe(struct i2c_client *i2c,
>  
>  	regmap = devm_regmap_init_i2c(i2c, &config);
>  	if (IS_ERR(regmap)) {
> -		dev_err(&i2c->dev, "Failed to register i2c regmap %d\n",
> -			(int)PTR_ERR(regmap));
> +		dev_err(&i2c->dev, "Failed to register i2c regmap %ld\n",
> +			PTR_ERR(regmap));

Another option would be to use %pe to print the error identifier
and not the error number

etc...