Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] drivers: iio: Drop unnecessary explicit casting
To:     Joe Perches <joe@perches.com>, jic23@kernel.org
Cc:     knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20200318100754.25667-1-nish.malpani25@gmail.com>
 <a7778635620163cb6185192819a56ed44d76d4b0.camel@perches.com>
From:   Nishant Malpani <nish.malpani25@gmail.com>
Message-ID: <9aa90ffd-9574-d615-0bc0-f791e51b3be4@gmail.com>
Date:   Sat, 21 Mar 2020 23:56:33 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <a7778635620163cb6185192819a56ed44d76d4b0.camel@perches.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 21/03/20 5:56 pm, Joe Perches wrote:
> On Wed, 2020-03-18 at 15:37 +0530, Nishant Malpani wrote:
>> Provide correct specifiers while printing error logs to discard the use
>> of unnecessary explicit casting.
> []
>> diff --git a/drivers/iio/accel/kxsd9-i2c.c b/drivers/iio/accel/kxsd9-i2c.c
> []
>> @@ -21,8 +21,8 @@ static int kxsd9_i2c_probe(struct i2c_client *i2c,
>>   
>>   	regmap = devm_regmap_init_i2c(i2c, &config);
>>   	if (IS_ERR(regmap)) {
>> -		dev_err(&i2c->dev, "Failed to register i2c regmap %d\n",
>> -			(int)PTR_ERR(regmap));
>> +		dev_err(&i2c->dev, "Failed to register i2c regmap %ld\n",
>> +			PTR_ERR(regmap));
> 
> Another option would be to use %pe to print the error identifier
> and not the error number
> 
By 'error identifier' you mean the symbolic error name (as described in 
docs [1]), right? Yes, to me, it makes sense too, as it would be more 
"readable" during debugging. Jonathan, if you agree, do I send a 
patchset replacing with %pe specifier for all the drivers in consideration?

With regards,
Nishant Malpani

[1] 
https://www.kernel.org/doc/html/latest/core-api/printk-formats.html#error-pointers

> etc...
> 
>