Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 21 Mar 2020 18:47:51 +0000
From:   Jonathan Cameron <jic23@kernel.org>
To:     Joe Perches <joe@perches.com>
Cc:     Nishant Malpani <nish.malpani25@gmail.com>, knaack.h@gmx.de,
        lars@metafoo.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: iio: Drop unnecessary explicit casting
Message-ID: <20200321184751.717f1d4d@archlinux>
In-Reply-To: <a7778635620163cb6185192819a56ed44d76d4b0.camel@perches.com>
References: <20200318100754.25667-1-nish.malpani25@gmail.com>
        <a7778635620163cb6185192819a56ed44d76d4b0.camel@perches.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, 21 Mar 2020 05:26:52 -0700
Joe Perches <joe@perches.com> wrote:

> On Wed, 2020-03-18 at 15:37 +0530, Nishant Malpani wrote:
> > Provide correct specifiers while printing error logs to discard the use
> > of unnecessary explicit casting.  
> []
> > diff --git a/drivers/iio/accel/kxsd9-i2c.c b/drivers/iio/accel/kxsd9-i2c.c  
> []
> > @@ -21,8 +21,8 @@ static int kxsd9_i2c_probe(struct i2c_client *i2c,
> >  
> >  	regmap = devm_regmap_init_i2c(i2c, &config);
> >  	if (IS_ERR(regmap)) {
> > -		dev_err(&i2c->dev, "Failed to register i2c regmap %d\n",
> > -			(int)PTR_ERR(regmap));
> > +		dev_err(&i2c->dev, "Failed to register i2c regmap %ld\n",
> > +			PTR_ERR(regmap));  
> 
> Another option would be to use %pe to print the error identifier
> and not the error number
> 
> etc...
> 
> 

Indeed that would be even better.  I'd missed that one being added
to the magic of prink :)

Jonathan