Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200317135649.8876-1-michael.auchter@ni.com> <20200317145113.12413-1-michael.auchter@ni.com>
In-Reply-To: <20200317145113.12413-1-michael.auchter@ni.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Sun, 22 Mar 2020 01:46:21 +0200
Message-ID: <CAHp75Veh3QRfqVFOpYbuuxcPqirc1_YrF-iZfRjNsYk7DWqYpQ@mail.gmail.com>
Subject: Re: [PATCH v2 1/2] iio: adc: ad7291: convert to device tree
To:     Michael Auchter <michael.auchter@ni.com>
Cc:     Lars-Peter Clausen <lars@metafoo.de>,
        Michael Hennerich <Michael.Hennerich@analog.com>,
        Stefan Popa <stefan.popa@analog.com>,
        Jonathan Cameron <jic23@kernel.org>,
        Hartmut Knaack <knaack.h@gmx.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-iio <linux-iio@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Mar 17, 2020 at 4:53 PM Michael Auchter <michael.auchter@ni.com> wrote:
>
> There are no in-tree users of the platform data for this driver, so
> remove it and convert the driver to use device tree instead.

...

> +       chip->reg = devm_regulator_get_optional(&client->dev, "vref");
> +       if (!IS_ERR(chip->reg)) {

Why not to go with usual positive conditional?

> +               ret = regulator_enable(chip->reg);
> +               if (ret)
> +                       return ret;
> +
>                 chip->command |= AD7291_EXT_REF;
> +       } else {
> +               if (PTR_ERR(chip->reg) != -ENODEV)
> +                       return PTR_ERR(chip->reg);
> +
> +               chip->reg = NULL;
> +       }

...

> +static const struct of_device_id ad7291_of_match[] = {
> +       { .compatible = "adi,ad7291", },

> +       {},

No need for comma.

> +};

...

> +               .of_match_table = of_match_ptr(ad7291_of_match),

No need to use of_match_ptr(). Haven't you got a compiler warning in !OF case?

-- 
With Best Regards,
Andy Shevchenko