Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: LU5tnGu79NI8ftd9DyBlDFfWc9lECniFP14v4zMKMHwf7tUaqe4yThJJpwniz3gXhdh+Z8by09
 j620MPSDGT7w==
IronPort-SDR: xxcblHMX2RBUykp4thoYSybBcZ9e/GoEScu8af4cI/GdBdJGgLUMtPkHogh2/F3OPZGlhfYb+L
 wKTOFtak/WxA==
Date:   Sun, 22 Mar 2020 02:25:42 +0200
From:   Andy Shevchenko <andriy.shevchenko@intel.com>
To:     Rohit Sarkar <rohitsarkar5398@gmail.com>
Cc:     linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        jic23@kernel.org, dragos.bogdan@analog.com,
        Lars-Peter Clausen <lars@metafoo.de>,
        Michael Hennerich <Michael.Hennerich@analog.com>,
        Stefan Popa <stefan.popa@analog.com>, knaack.h@gmx.de,
        pmeerw@pmeerw.net
Subject: Re: [PATCH] iio: gyro: adis16136: use scnprintf instead of snprintf
Message-ID: <20200322002542.GA2826015@smile.fi.intel.com>
References: <5e723666.1c69fb81.3545b.79c3@mx.google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5e723666.1c69fb81.3545b.79c3@mx.google.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Mar 18, 2020 at 08:25:22PM +0530, Rohit Sarkar wrote:
> scnprintf returns the actual number of bytes written into the buffer as
> opposed to snprintf which returns the number of bytes that would have
> been written if the buffer was big enough. Using the output of snprintf
> may lead to difficult to detect bugs.

Nice. Have you investigate the code?

> @@ -96,7 +96,7 @@ static ssize_t adis16136_show_serial(struct file *file,
>  	if (ret)
>  		return ret;
>  
> -	len = snprintf(buf, sizeof(buf), "%.4x%.4x%.4x-%.4x\n", lot1, lot2,
> +	len = scnprintf(buf, sizeof(buf), "%.4x%.4x%.4x-%.4x\n", lot1, lot2,
>  		lot3, serial);
>  
>  	return simple_read_from_buffer(userbuf, count, ppos, buf, len);

The buffer size is 20, the pattern size I count to 19. Do you think snprintf()
can fail?

-- 
With Best Regards,
Andy Shevchenko