Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp2347375ybb; Sat, 21 Mar 2020 19:58:54 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtFAhMQihSd0Ea3YdhOTG45zHe7JK576MJbvRszxoWYZ9mFt2BF8teAErXdflDabKFmFl4e X-Received: by 2002:aca:5a56:: with SMTP id o83mr196147oib.134.1584845934863; Sat, 21 Mar 2020 19:58:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584845934; cv=none; d=google.com; s=arc-20160816; b=ByuPobmcgtVfeyVexN1NgruBHetb/WXhYgPuTQJrXsi9zz19CGY63m/Yy5lQZHunCX wAigWt4VemoknyT98ajbcIIWTea9h0NF4MkCjSRdJAlM2oc9FybmWJ0YJ/69lZgMCOWN 8jriSY51tWJ03XSRIMGw149XrbsOubqfCFYMRgECOFYpf0uqYPPIN4dqWW8WsF4lMxLF MVG2TBSEvzbwqoG5GzZ03FNPeT6Gv4V1v+KK6KgXpCK/SvKPCsFsBztv1BylRyR4I5Me XLA7JMOnqm+/ASGWYsfUaqHMFQkYH3v+qSwXaJ4b3sh0Rht7iW9eT+gqUD3/0PhRP26s M5Og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:dkim-signature; bh=XTs9KDLLrOFqZAv2EfXEwbo/Qe8dov8hUy1o607A6jg=; b=CmyQiw5CNTlTZnx0usB4wQjNetwHo9QDOWiYrUHre8/TivNLstpqcoNYarTBqxdxAB HlYk7YJAL5mpFeoDeo+XBKX1FkpxMcOd9IPllMh27mJFKXD3KL385ecxt9TVxcU+drQS +BT3BUhxNA19pafpuJMYThv1zlWD2s8MCPQat/9YlyVk0wDCBKCkWDyw2OwyF0xptggn rTXv93bUhXxR/d+2ErEiVwoRyKz8oKYh9mStszNq8F1nVStnm7HzAqRG0wQQN8ekmkM9 RJlEmzGBwW9SHwhxzYk3+se8THLqinhjhj3Oi70T6flMQOHJBZsw+bT4Q8T3WWlx1wmi aS3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=UB3AYpq4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f9si6000279oti.44.2020.03.21.19.58.42; Sat, 21 Mar 2020 19:58:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=UB3AYpq4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728316AbgCVC5R (ORCPT + 99 others); Sat, 21 Mar 2020 22:57:17 -0400 Received: from mail-pj1-f68.google.com ([209.85.216.68]:54075 "EHLO mail-pj1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727296AbgCVC5R (ORCPT ); Sat, 21 Mar 2020 22:57:17 -0400 Received: by mail-pj1-f68.google.com with SMTP id l36so4383146pjb.3; Sat, 21 Mar 2020 19:57:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=XTs9KDLLrOFqZAv2EfXEwbo/Qe8dov8hUy1o607A6jg=; b=UB3AYpq4xJwBNoaUE9tlQAyq2Ov/HC7l5uAyZv/RVs5cVLP4ZBNjeNOq3giiNHG9QB 1k5cNXmGzaRb25ZgWjmZc12MrxaBFiTUUX0KBo38fl3HzwoYS5Nen8aMf/aJQnLW5O/U p7HQXOsg+qx86TjDPO83Bbk6V0wZA2knE6+frJTC5TwHTLR+7F6WHDVvQT3BZOT8L76l ti7cCgg2tDD7FSmzLjz4377VrdEikU+LDAoSUGUg1p0BoS5JR1/qWufgfeZsY5GVyIvO lHljBHura0L4/roon5iL4yb4m2HIDMHn3K+OoThcFnj5IHHo/xWHZy5DqMqPAp3dwNNB /UKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=XTs9KDLLrOFqZAv2EfXEwbo/Qe8dov8hUy1o607A6jg=; b=d4ldUFLS4sm8FQGPzgvfEqk26W3f7qcQGLOBhEwxQzUYjphzOlgmp58b0dAsh44tMZ U+JO0Cyhmmd1LrSMAtYErH4DZr6lrI6HhY2q2NmmwGhYHdU1lEC33L9KxKiU25ggic+U j/qQOg1N9309R4U9VRU8YJiJ49KArisbebkYH1sjH/BSdhSOfUDPCDPxKlvKdivNK0yD C/iXhhKmWNdA/G5wUYaAsUV7e2b4rhtoEkeL+6efQxdIbFNLntgUeMbaML34WsgzTKBC gkvAIkWffAX3FyCpeYtDJC+iP65dTvvtII70MqZjC4pL/L86RHRD1xgSw+cNLFjxWuTj gxhQ== X-Gm-Message-State: ANhLgQ3GOBUujahsL9udLhlQYkTmKPjnt7Jk+OI0911tnzN5R7A+YUHA Q0t2vwl5GL8/zWUTb9YaOxfOUNpe X-Received: by 2002:a17:902:a701:: with SMTP id w1mr14256054plq.165.1584845833659; Sat, 21 Mar 2020 19:57:13 -0700 (PDT) Received: from [192.168.1.3] (ip68-111-84-250.oc.oc.cox.net. [68.111.84.250]) by smtp.gmail.com with ESMTPSA id l2sm8327396pjn.27.2020.03.21.19.57.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 Mar 2020 19:57:13 -0700 (PDT) Subject: Re: [PATCH net-next v3 7/7] net: phy: use phy_read_poll_timeout() to simplify the code To: Dejin Zheng , andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, allison@lohutok.net, tglx@linutronix.de, gregkh@linuxfoundation.org, mchehab+samsung@kernel.org, netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org References: <20200322024834.31402-1-zhengdejin5@gmail.com> <20200322024834.31402-8-zhengdejin5@gmail.com> From: Florian Fainelli Autocrypt: addr=f.fainelli@gmail.com; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: <242d4d32-8559-4ffc-9272-7ee1efc30793@gmail.com> Date: Sat, 21 Mar 2020 19:57:11 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Firefox/68.0 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200322024834.31402-8-zhengdejin5@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/21/2020 7:48 PM, Dejin Zheng wrote: > use phy_read_poll_timeout() to replace the poll codes for > simplify the code in phy_poll_reset() function. > > Signed-off-by: Dejin Zheng > --- > v2 -> v3: > - adapt to it after modifying the parameter order of the > newly added function > v1 -> v2: > - remove the handle of phy_read()'s return error. > > drivers/net/phy/phy_device.c | 16 ++++------------ > 1 file changed, 4 insertions(+), 12 deletions(-) > > diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c > index a585faf8b844..cfe7aae35084 100644 > --- a/drivers/net/phy/phy_device.c > +++ b/drivers/net/phy/phy_device.c > @@ -1059,23 +1059,15 @@ EXPORT_SYMBOL(phy_disconnect); > static int phy_poll_reset(struct phy_device *phydev) > { > /* Poll until the reset bit clears (50ms per retry == 0.6 sec) */ > - unsigned int retries = 12; > - int ret; > - > - do { > - msleep(50); > - ret = phy_read(phydev, MII_BMCR); You are doing some subtle changes here, the sleep used to be *before* the read of BMCR and now it will be *after*. If there were PHY devices that required 50ms at least, but would incorrectly return that BMCR_RESET is cleared *before* 50ms, then we would be breaking those. I would recommend we drop this patch for now, the rest looks good to me though. -- Florian