Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp2360292ybb; Sat, 21 Mar 2020 20:21:28 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuZk3VayKgsLiAxCklsXWwXPbmhOKSbxjgOK5iJMV+XQCQGDcXXWiS1P84ZbRDCNB5AXkAj X-Received: by 2002:aca:d68e:: with SMTP id n136mr12854358oig.103.1584847288383; Sat, 21 Mar 2020 20:21:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584847288; cv=none; d=google.com; s=arc-20160816; b=rloK1AFiRexdV1CosD4o6Jq/wMdeAY2x9WuwdjMAbPaQ+WL+V3Xfr2Bftx1KgKqsUQ o9Z8iz9cm8KwI3SHoNUeUTDeeD1/l99jJWwkZXGKkAhFailL0Quj+Vc0XcTZIsBV1XYo B8YXVBfHDOwQkY26/BGwP7uLiAdizgefKFGOYbecqKEmX9hv7QITl6mLPwx7+Vwyh0ph 1YsH+oSAS7i49YHpGzzGRQ7+KToXAntIMDCUpFsIYcoMGvaSsoNcgvzUmxbhbVb2/pcX o/z97K5QPcGZK4DR6MYBSjRXY6dIHaQ0JGtHOKuQqlGMWF4/6nOMdRaoRGewFTXSvz0V AANQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=dDpp/lAHZIV9/PeB62EoDADzvZvkW06yy69SEs7kI10=; b=ISSH9w6lE3um3YLFOvRx0EKsWoFnOyymJ+ksuyBNZX7num6Gn9zYKqEb5ZCFu2yFaJ 8Csvh/7ku48s5Hz2gl8dpB+cgDvgiwnwKiag6rGCOANUrgOWxFbD5uTPZX+pSltV79VS j0zofpQjHRvLSsBE2Jn4vuzYypFoDICcpk5L4Ks15psQkHhfncWrzJpZAeZTi8Kapzcp qutafZjenAm/pNpnMMFBV0ubQpKepaT4ZBq89wrAFqGk6VgzcXMANFCt3PlilBbfCoeE Guxum/V7ujnmkDeQno4+XQhPSLixBFPQNVrTW4341LtsBJf+Ae6dzygk/wl/NOO7UwFZ pIIQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k22si5846735otn.272.2020.03.21.20.21.14; Sat, 21 Mar 2020 20:21:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728351AbgCVDUS (ORCPT + 99 others); Sat, 21 Mar 2020 23:20:18 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:34454 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727296AbgCVDUR (ORCPT ); Sat, 21 Mar 2020 23:20:17 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 1F88C15AC4293; Sat, 21 Mar 2020 20:20:17 -0700 (PDT) Date: Sat, 21 Mar 2020 20:20:16 -0700 (PDT) Message-Id: <20200321.202016.815058339704760980.davem@davemloft.net> To: hkallweit1@gmail.com Cc: acelan.kao@canonical.com, nic_swsd@realtek.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] r8169: only disable ASPM L1.1 support, instead of disabling them all From: David Miller In-Reply-To: <78aa4db2-6dec-e23c-03f4-f76577de756f@gmail.com> References: <20200318014548.14547-1-acelan.kao@canonical.com> <78aa4db2-6dec-e23c-03f4-f76577de756f@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 21 Mar 2020 20:20:17 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Heiner Kallweit Date: Wed, 18 Mar 2020 12:09:14 +0100 > Having said that I'd prefer to keep ASPM an opt-in feature. Agreed, too much stuff broke randomly and in hard to detect ways.