Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp2360492ybb; Sat, 21 Mar 2020 20:21:52 -0700 (PDT) X-Google-Smtp-Source: ADFU+vubBRoL+nGzvAS7f5SjQSmu8ZrvWKAtyveeChiMNuRZDEhQ1bxvqEDSWUUrqwwDJZKmi+9R X-Received: by 2002:aca:c608:: with SMTP id w8mr12746561oif.163.1584847311929; Sat, 21 Mar 2020 20:21:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584847311; cv=none; d=google.com; s=arc-20160816; b=svSlNpXQafvaL8sQPGXUKgVUuy84XnZAM+c5JNy1AlfY0ULsu4mpfKw87rUj3ZloQk oJlsegZ7o5TvajyKcVV04YyaTAuBlB9+daOIyRhmI+zYeAUeZxBwHa2no/+bp97QzSHL BENtX1tWfS2SkAdH7JNH4Rtr8qrZ/OLXIVes3DJhRtevWkhAMCUALZbv6kP5vRLkhgMS WJ65GJvTMdkbygA/Kt8QJeID2nT6qT+mQYWdVTi7vHCtaqI5sB+4PPsgCNH0ObALX1ub l1Lm/dWMdLzZoXoTyMLbyvK6LKipJeNCjvO85Kl2X9iK7qwNNo/aDpm0gbRXlwG5VDcF YGEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=ecz9iBHw+vzjfXTEnON2ejOYC9o9a++vM/gTBDqVlh8=; b=NBSgn7JPwpOaaMdIdn0QAEHBISghgaiX0DThwE0B/HL4MAox5Zy80ud53f9g5362fC 8j+fbqAmgxW7D3q7SzV3IXU4OcN/Hy3uNT09mfzG8sBVPl4Iba+8LO0sDQ+KtZSQtOvZ kD8dgNRm/LX+bOh/hfNiOXDNVT/z6zqEvqPtIWzllgOF4cH07621075Fe2rAN7Z7X5GR d59JDfn0chhT1q5xNsPN7hiMapWCi9UJH63kZF4i0u9briOaCqAroe4XwfvU8oPcjKoD Il69mGK/pma9D1cmC0/5o+1XzTfVjxfnfQS0GmZ+imb/2PHsNfZVjmuj2+32ksjx8olp kKEw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f50si5773888otf.139.2020.03.21.20.21.39; Sat, 21 Mar 2020 20:21:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728371AbgCVDVF (ORCPT + 99 others); Sat, 21 Mar 2020 23:21:05 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:34468 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727689AbgCVDVF (ORCPT ); Sat, 21 Mar 2020 23:21:05 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 19C0015AC429C; Sat, 21 Mar 2020 20:21:04 -0700 (PDT) Date: Sat, 21 Mar 2020 20:21:03 -0700 (PDT) Message-Id: <20200321.202103.682709364176957538.davem@davemloft.net> To: yuehaibing@huawei.com Cc: mathew.j.martineau@linux.intel.com, matthieu.baerts@tessares.net, pabeni@redhat.com, kuba@kernel.org, netdev@vger.kernel.org, mptcp@lists.01.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] mptcp: Remove set but not used variable 'can_ack' From: David Miller In-Reply-To: <20200318020157.178956-1-yuehaibing@huawei.com> References: <20200318020157.178956-1-yuehaibing@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 21 Mar 2020 20:21:04 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: YueHaibing Date: Wed, 18 Mar 2020 02:01:57 +0000 > Fixes gcc '-Wunused-but-set-variable' warning: > > net/mptcp/options.c: In function 'mptcp_established_options_dss': > net/mptcp/options.c:338:7: warning: > variable 'can_ack' set but not used [-Wunused-but-set-variable] > > commit dc093db5cc05 ("mptcp: drop unneeded checks") > leave behind this unused, remove it. > > Signed-off-by: YueHaibing Applied, thanks.