Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp2373867ybb; Sat, 21 Mar 2020 20:46:54 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtYPZ4LmVVvaqMmDUmzhUM3rkUt3U3wCAvq0ZmE3D8CP4GHytqR3yQEtLB/WOjQqypXJ8PB X-Received: by 2002:a54:448c:: with SMTP id v12mr12913467oiv.107.1584848814516; Sat, 21 Mar 2020 20:46:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584848814; cv=none; d=google.com; s=arc-20160816; b=XtQp8yBeK+o+CHm6SXwjwNChctG2rzjv8g0JooaDDlm4gQ3mdYCEFIF5x7FIGNCdsh Rbc9bWQ7v14YXjZWIoJTB8QqH6S1BtNzVr1qxy4yNUY9IXCFup7ggENevIUkQo80jl4n dX8xBFpsSR+z/Qq4vcYTAhP/lkWiSuR/V2pQgkg/RW09Mk77IDOAHA9TVDhAtD+Kl0GW xe86HEKlKojE+U9Eu8rq0u3lYFxLSjaW6sDwKnj6J+bXh2e+CdT9JfYK64+ZgchJx0Bk uI+fMaPSac2LgnH00cEpwaq10FUbMId2B+cXgRYlAHVNEsqVi+vkI/Nri/wr62NMbaeu 3m1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=1YJ+j0lJzi+J8lWCUUnPHq3BCTndbwZM0k4s44sq0KI=; b=ul7iHbDY8cjc+XOdVHZLwX1C6Qi7j+xPRyEtrsIUBOsWA/3d8Ms/jngPOb/TbG/DSw 95xjK0da8bXpCEto26ap+nvjvAJ9/N2c+XtK371rR9UWvlNS6Y5zq6MUaIZcOQuozrjy sY8mZ8flzN+qu2Id93uoB6zgtywqcH0BNBIYYLGJV0iooMQJ2WB2MYWtw2rf67J3v4gr wDL7LeN+DaVSmaFlkVJIn+68xivLHVJafhBtOn2CpUMIuP9ccJoWeTlfxtNc24FmJzrO 9SOxO9/TuQJWtnwM0imBB1yU8h5FsHtMA4Yy8Rygv3jSp6bdIpdctPPo1qLK+8v8+JFZ Yivw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=OiPOSp6N; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j84si5585243oia.126.2020.03.21.20.46.42; Sat, 21 Mar 2020 20:46:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=OiPOSp6N; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728219AbgCVDo3 (ORCPT + 99 others); Sat, 21 Mar 2020 23:44:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:49928 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727700AbgCVDo2 (ORCPT ); Sat, 21 Mar 2020 23:44:28 -0400 Received: from sol.hsd1.ca.comcast.net (c-107-3-166-239.hsd1.ca.comcast.net [107.3.166.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 20D9C206F9; Sun, 22 Mar 2020 03:44:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584848668; bh=PdGUyDr5TNiAHER+Gc7L/PkOPiHYfEpX9aUbK6v+tag=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OiPOSp6N0Bcq1WSJJK+EAhU3wTCEcSQUmP/2S2NSc0rUb8LUzjkaM4md3IE3ZFtGP Z+/+XyAgPICM9sWDDmIa/Hv28n03/b8fXM+pmduMlHff8oH02gw9VXcNpJf9RPi7vC /gq7vNobay9YJf3JSYG4H3lpVCtu8hS/t/2I8Xao= From: Eric Biggers To: Greg Kroah-Hartman , Jiri Slaby Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, syzkaller-bugs@googlegroups.com, Eric Dumazet , Nicolas Pitre Subject: [PATCH v3 0/2] vt: fix some vt_ioctl races Date: Sat, 21 Mar 2020 20:43:03 -0700 Message-Id: <20200322034305.210082-1-ebiggers@kernel.org> X-Mailer: git-send-email 2.25.2 In-Reply-To: <20200320193424.GM851@sol.localdomain> References: <20200320193424.GM851@sol.localdomain> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix VT_DISALLOCATE freeing an in-use virtual console, and fix a use-after-free in vt_in_use(). Changed since v2: - Implemented tty_port_operations::destruct(). - Added comments regarding vt_in_use() locking. Changed since v1: - Made the vc_data be freed via tty_port refcounting. - Added patch to fix a use-after-free in vt_in_use(). Eric Biggers (2): vt: vt_ioctl: fix VT_DISALLOCATE freeing in-use virtual console vt: vt_ioctl: fix use-after-free in vt_in_use() drivers/tty/vt/vt.c | 23 ++++++++++++++++++++++- drivers/tty/vt/vt_ioctl.c | 28 ++++++++++++++++------------ 2 files changed, 38 insertions(+), 13 deletions(-) -- 2.25.2