Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp2646332ybb; Sun, 22 Mar 2020 04:29:16 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtE1isgTKTQ54O3AwcLZD2Qu8OnXI1D5U9UN3webiMMToC6Si3htfD/mxQXjwjF32i69kA6 X-Received: by 2002:a9d:5781:: with SMTP id q1mr3140070oth.258.1584876556236; Sun, 22 Mar 2020 04:29:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584876556; cv=none; d=google.com; s=arc-20160816; b=fl+bzyssNaSF1T2D7L5jyFO6R7wc3Pz3fiSRAVx5xMh6Ji6kErbCUeBXSQnSq1GVkI RLndmnQAqdkebcQN147r1BGAE/nwhlhr0I7mxrcLyiciOKMz6GRoA4Id99bfMQHpKImA z+Vyg1otRLgnMdLAYTrm6c5huikTAqJN25MpSAQ9avsQwoNco5/XJRmmsiOodbhBvTAl wPf28pVBYdVMOu2aO7BguTgXUF2e4wJnLBjBPepBa1itbSnZBebSyB+Sove9+y9Bn1HJ cV35R8APfiYmu/IlEVo0k78pMT8jGCapYNiEZthjU2kZ6tCOecm+voKqnQvez5bn5guW RjTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=MiRWCSXSrrm/oDu/jhrLgCQHfq3wo0rdYWSgXnYr8jA=; b=bVwA0ctzx83Xd0XmKmkkkgemQ2bk00v5j+Kr8DOGwPlKdPIPm6e17MMphvhDhK0pgR qexVvp2bWWIhfg8h/2cExqKkwQBRG1eLZDiKtwK4WBopC3XEs9T7PSL5MVa3JuYEaPAW 57Y85/B8U5zf3MLi9gXQT3OdAt3wB2wVDNX0ImQf3XmP6vMzoxi/pCaDkPRm2mLJ+CeW r8c1GQWH0SIO45jerbXGmdOGFNkyXctr76qUNiSyVWIDucSQu0gdwxJRkOavVLeoAZqD J3JWcLSkanEf2VuzNiVhvLW7HPuJSmZo6sQktbT1Qv/wp6DAI73ijSWhrhM7HaabvJ67 vleQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="fm/5Npgl"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b12si8306121ots.192.2020.03.22.04.29.03; Sun, 22 Mar 2020 04:29:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="fm/5Npgl"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727059AbgCVL1r (ORCPT + 99 others); Sun, 22 Mar 2020 07:27:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:56202 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726954AbgCVL1r (ORCPT ); Sun, 22 Mar 2020 07:27:47 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0BEFE20714; Sun, 22 Mar 2020 11:27:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584876466; bh=Zlt25t7XisTrtu+UdnuJ5QG6TBUbTde7SUL83ydeDjQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fm/5Npgl1pGyF0sBACsLEEeeXNojurSvhC1lKABFeruhHdMdEmHj74QyF1cDqq3OT eeMrO7OpPpQYOVLGqJrkMFLzrL8/2FSpRf/nIG5jlVWTsiaUjIxKLNFce89CsvHfWt oEYX+JwfYlrYBoJIdS1oMpvGiDqUbbRDwqQ7sTXA= Date: Sun, 22 Mar 2020 12:27:44 +0100 From: Greg KH To: Shreeya Patel Cc: Larry.Finger@lwfinger.net, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH 01/11] Staging: rtl8188eu: hal_com: Add space around operators Message-ID: <20200322112744.GC75383@kroah.com> References: <19950c71482b3be0dd9518398af85e964f3b66b1.1584826154.git.shreeya.patel23498@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <19950c71482b3be0dd9518398af85e964f3b66b1.1584826154.git.shreeya.patel23498@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 22, 2020 at 03:51:13AM +0530, Shreeya Patel wrote: > Add space around operators for improving the code > readability. > Reported by checkpatch.pl > > git diff -w shows no difference. > diff of the .o files before and after the changes shows no difference. There is no need to have these two lines on every changelog comment in this series :( And pick a column to line wrap on (usually 72) and stick with that. You are using two different ones here, and for this whole series, and it looks very odd, don't you think? thanks, greg k-h