Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp2810320ybb; Sun, 22 Mar 2020 08:14:14 -0700 (PDT) X-Google-Smtp-Source: ADFU+vs7a7LDuYSYeTQ8bO7Hzn0iLUTdELCfd3U3lkfMlHS7IFCMZBnfBzY6UYBX8y3pEiSuXbbM X-Received: by 2002:aca:5652:: with SMTP id k79mr13912656oib.15.1584890054066; Sun, 22 Mar 2020 08:14:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584890054; cv=none; d=google.com; s=arc-20160816; b=T1wgoMw1QLyVnhaIYVDKNP1jUVe2iKpZsrtx26Jg4eOmhKulpxzL5ivEUTn16EqEKG 2sjusDVMYyGLKsLNdpC6/mSdYU0/OjH91QETJkgPqZLCSsQVZQV0OadLhYee17jVneO+ oa+aalWLZxqIV0beDZDuqapPEZHYMfhnwaoS5t8vHvFS+3M0ujh+nEHNcn6OyoZl/oSQ TNz+k8sahlbcvSxD7D9oDQ1YuZlThDdNqdtXuKlEeSHyxE8QYtjAk5vaaYc2FwzZMpWZ pOTabXJz+NRTalL8WEFQcpNXgt+OVCKAVcvePVGNEa8ijz8qZDoyMDH8RUNbfY27ihL7 V28g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=Nc91eu0k70tqYlwgZ/RXBB28QqiUTANWAUI0rLVhm4k=; b=Zp/reDb605QSZZvoymUcJmMztTHcoYo5NORSP4YxjTtNm1FJsCawDR+KjiVQoBO76D DMl5WuPJg0YomL3xusr26M3MRUnpP+VmoclWzhsV7s8GUCVb4S0bgeQ1npR4J2NxFEy8 vCmQzh/VxZ4gjpF/rLVhSmRopmfMGC84VJeD2tfKquE3y8svniCv3oYylRyXOfqiYU9x jZYseI2peTPgPuPcuF42/SJmXGKuYmMRHb+V9WCLONUtymGujrxAT/gETgY9fFpgpa0Q aFz3cPGEThEp1KEBYrQYBf+Ge5ik27Cz67x6cV5/3I0n93/cFIZNErvgj4QEnNoiB2Cf OUjQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 66si6027092otx.151.2020.03.22.08.14.01; Sun, 22 Mar 2020 08:14:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726880AbgCVPLR (ORCPT + 99 others); Sun, 22 Mar 2020 11:11:17 -0400 Received: from smtprelay0151.hostedemail.com ([216.40.44.151]:36538 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725785AbgCVPLR (ORCPT ); Sun, 22 Mar 2020 11:11:17 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay07.hostedemail.com (Postfix) with ESMTP id EEC47181D2FE4; Sun, 22 Mar 2020 15:11:15 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,,RULES_HIT:41:355:379:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3874:4250:4321:5007:6691:7903:10004:10400:10848:11232:11658:11914:12297:12740:12760:12895:13069:13161:13229:13255:13311:13357:13439:14096:14097:14181:14659:21080:21627:30012:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: talk44_7f4b0ad682943 X-Filterd-Recvd-Size: 1813 Received: from XPS-9350.home (unknown [47.151.143.254]) (Authenticated sender: joe@perches.com) by omf11.hostedemail.com (Postfix) with ESMTPA; Sun, 22 Mar 2020 15:11:14 +0000 (UTC) Message-ID: Subject: Re: [Outreachy kernel] [PATCH 01/11] Staging: rtl8188eu: hal_com: Add space around operators From: Joe Perches To: Greg KH , Shreeya Patel Cc: Larry.Finger@lwfinger.net, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Date: Sun, 22 Mar 2020 08:09:26 -0700 In-Reply-To: <20200322112744.GC75383@kroah.com> References: <19950c71482b3be0dd9518398af85e964f3b66b1.1584826154.git.shreeya.patel23498@gmail.com> <20200322112744.GC75383@kroah.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2020-03-22 at 12:27 +0100, Greg KH wrote: > On Sun, Mar 22, 2020 at 03:51:13AM +0530, Shreeya Patel wrote: > > Add space around operators for improving the code > > readability. > > Reported by checkpatch.pl > > > > git diff -w shows no difference. > > diff of the .o files before and after the changes shows no difference. > > There is no need to have these two lines on every changelog comment in > this series :( In my opinion, there's no need for a series here. Whitespace only changes _should_ be done all at once. Whitespace changes _could_ have changed string constants. So noting that the patch in only whitespace and that there isn't a difference in object files is useful as it shows any change has been compiled and tested.