Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp2811029ybb; Sun, 22 Mar 2020 08:15:13 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsUmPI61l1irh1h2h9867FZ9ZVdTaTLLZxWZy+Q1txZJ8y1CMHsvtf9x2VFLtvQxCq+g4xC X-Received: by 2002:a9d:6009:: with SMTP id h9mr1377067otj.168.1584890112907; Sun, 22 Mar 2020 08:15:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584890112; cv=none; d=google.com; s=arc-20160816; b=Z5Qu2NH0XIwtZnkJQIb6awmdKXScU27gFRdZqQGjWQHozUgk6UOPuMYu9n9ZkT24lg y+Comxrshb/w58evp31vw9g2z6oiolcVPoJpr74Rx58BY79zQL+MVUD7nuEN162HxDlr JfMvBCm4sTNzUMayfONOgcNVC/wpAQ7zETV+c3+TwIWGrjvgXLq+2N1WDDG/T28HfQg0 nTLe6cA3k0HUQSDJ19CIvz208ca0AMjm96k7z/furhAOgDSi0tk9CPPZo394Sa0Lmt9d AuGSiGhh6L1iIMMkATAcWNoCBQRj2OcRkxy6a7MUCYiN6L/2bS4QJyanBPeHeh+GXrUA PKHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=jU1tZN9SvriQuTPAY9v52hKU3vRtjkoA4roKYV/o0ys=; b=ML/zQsZSuZSBeN/GwUuCGBJ4bc/eXAETWXfuCmPESzoaS2EiJH7uhQ9Ue5no5KF2T1 oJJV2DEVrP/swZKEwzlReZdkBKudmijbu/FPGYgWya6OqsQ3pL+pNHSPp1VxHv1J4M1i YeaZT6MyypRI+oODf1NwjlY8HmLnPez6/lTKw6pjDnorMXoqviAAir5Eqtm9AFsDtpE+ 9vmeV4ReyLNy3My9uyC7/G+W1nrmE+sHWj8wbko7ONeHbakLS05Cjm50oj/2rQdDaYDD mtp/IBcuxVNIg05y2v6Y5jI5D4VJxgZjlXrcVuvrDJxB6K38oIsZpdmhG1nlmlPh2XOC 7a0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=d7DJJwA+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c25si5990914otf.91.2020.03.22.08.15.00; Sun, 22 Mar 2020 08:15:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=d7DJJwA+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726902AbgCVPOE (ORCPT + 99 others); Sun, 22 Mar 2020 11:14:04 -0400 Received: from mail-pj1-f66.google.com ([209.85.216.66]:55728 "EHLO mail-pj1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726810AbgCVPOD (ORCPT ); Sun, 22 Mar 2020 11:14:03 -0400 Received: by mail-pj1-f66.google.com with SMTP id mj6so4892699pjb.5 for ; Sun, 22 Mar 2020 08:14:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=jU1tZN9SvriQuTPAY9v52hKU3vRtjkoA4roKYV/o0ys=; b=d7DJJwA+X2FK84QrpDwYCttb8rdd2e4lT8+Q5t70Gv2OgQB48UzwilKy9HxnqIx0u6 Pw5Oc4gmv7sKIZukyv/OadTHJirAPW4rkMqZHFbHOgACPEw7NSmh3qZcMhkhuTUlmksz H9RtOhwhEi0o2YorU6S02Z6fTWGneSV7k9tLM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jU1tZN9SvriQuTPAY9v52hKU3vRtjkoA4roKYV/o0ys=; b=aoEZsKaD3o7s4OTV9b/1xidTiLR/ZxIeomVb6ySmJqwZ9SbAwzlBWzQkMXtm9reIq1 JHpvo8+T1RFIrfo2yokPmDloyX5JoNsRBjszr+zCewD7NPglwxg9WOayJFXOzZpSw/qn JOtPSs1oG/ixR4ba5SzhW2xatDztZnyb973YS00yOr5d+ADEAMdF3MZxZdKM33B1HMkY LA42PwyI1KIKmkI7hgL4fbmTSYgBLWKEo/I9uWozXrDoeJXrQeYSYDwCP9LraUXmX7PN klgvDD7xQL3vHlpMTgY/xCdeAI4BAIfB9BChw738hL9MDOcvdQiv0mNkc8w1twjKeGxl hylg== X-Gm-Message-State: ANhLgQ0HVvVoPrXgvZ2dKMu2FxJ+Fmje2sPhkPwi5P6NsP4jvdtQGCtj 6C32EftT/pZ81vUwRfVHFJ0ZRg== X-Received: by 2002:a17:90a:3589:: with SMTP id r9mr20229184pjb.196.1584890042470; Sun, 22 Mar 2020 08:14:02 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id i2sm10807108pfr.151.2020.03.22.08.14.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Mar 2020 08:14:00 -0700 (PDT) Date: Sun, 22 Mar 2020 08:13:59 -0700 From: Kees Cook To: WeiXiong Liao Cc: Anton Vorontsov , Colin Cross , Tony Luck , Jonathan Corbet , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Mauro Carvalho Chehab , "David S. Miller" , Rob Herring , Greg Kroah-Hartman , Jonathan Cameron , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Subject: Re: [PATCH v2 11/11] mtd: new support oops logger based on pstore/blk Message-ID: <202003220812.5728216E0@keescook> References: <1581078355-19647-1-git-send-email-liaoweixiong@allwinnertech.com> <1581078355-19647-12-git-send-email-liaoweixiong@allwinnertech.com> <202003181149.90B22E24@keescook> <69b0133c-dfa3-2680-2a2e-473033750703@allwinnertech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <69b0133c-dfa3-2680-2a2e-473033750703@allwinnertech.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 22, 2020 at 09:51:19PM +0800, WeiXiong Liao wrote: > The physical features of MTD device require that the user configurations > must meet some requirements. For example the record size must be > multiples of page size of MTD flash. It's really different to block device. > If we make this device driver "invisible", we should have other way to > limit user configurations. The dmesg pstore front-end is the most easiest > one to fix to. There are still much work to do to support other front-ends. I finally understand this now -- I was still thinking of things like nvme which ultimately expose a block layer. MTD appear to genuinely be a "non-block" device. But it is still considered a "storage" device, yes? So perhaps "block storage device" and "non-block storage device"? -- Kees Cook