Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] arm64: dts: rockchip: fix defines in pd_vio node for
 rk3399
Cc:     devicetree@vger.kernel.org, heiko@sntech.de,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-rockchip@lists.infradead.org, robh+dt@kernel.org
References: <20200322140046.5824-1-jbx6244@gmail.com>
 <48a91cc1-7751-4df0-a2cd-940eb829fa16@gmail.com>
From:   Johan Jonker <jbx6244@gmail.com>
Message-ID: <1a6f0ba0-c49c-c547-1252-eed404655f43@gmail.com>
Date:   Sun, 22 Mar 2020 17:14:54 +0100
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <48a91cc1-7751-4df0-a2cd-940eb829fa16@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
To:     unlisted-recipients:; (no To-header on input)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

Why is 'pd_tcpc0, pd_tcpc1' grouped under 'pd_vio' instead of VD_LOGIC?

Thanks

On 3/22/20 4:45 PM, Johan Jonker wrote:
> Hi,
> 
> The RK3399 TRM uses both
> 
> 'pd_tcpc0, pd_tcpc1'
> 
> as
> 
> 'pd_tcpd0, pd_tcpd1'.
> 
> What should we use here?
> 
> Thanks.
> 
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>> index 8aac201f0..3dc8fe620 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>> @@ -1087,12 +1087,12 @@
>>  					pm_qos = <&qos_isp1_m0>,
>>  						 <&qos_isp1_m1>;
>>  				};
>> -				pd_tcpc0@RK3399_PD_TCPC0 {
>> +				pd_tcpc0@RK3399_PD_TCPD0 {
>>  					reg = <RK3399_PD_TCPD0>;
>>  					clocks = <&cru SCLK_UPHY0_TCPDCORE>,
>>  						 <&cru SCLK_UPHY0_TCPDPHY_REF>;
>>  				};
>> -				pd_tcpc1@RK3399_PD_TCPC1 {
>> +				pd_tcpc1@RK3399_PD_TCPD1 {
>>  					reg = <RK3399_PD_TCPD1>;
>>  					clocks = <&cru SCLK_UPHY1_TCPDCORE>,
>>  						 <&cru SCLK_UPHY1_TCPDPHY_REF>;
>> -- 
>> 2.11.0
>