Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 1/1] io-wq: close cancel gap for hashed linked work
To:     Pavel Begunkov <asml.silence@gmail.com>, io-uring@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <b9bc821a0ff3bc52a60281d8a9005dff93f6dcc3.1584893591.git.asml.silence@gmail.com>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <c7f352b4-0255-d87a-1fb4-0b55984df137@kernel.dk>
Date:   Sun, 22 Mar 2020 11:04:55 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <b9bc821a0ff3bc52a60281d8a9005dff93f6dcc3.1584893591.git.asml.silence@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 3/22/20 10:14 AM, Pavel Begunkov wrote:
> After io_assign_current_work() of a linked work, it can be decided to
> offloaded to another thread so doing io_wqe_enqueue(). However, until
> next io_assign_current_work() it can be cancelled, that isn't handled.
> 
> Don't assign it, if it's not going to be executed.

This needs a Fixes: line as well. I'm guessing like this:

Fixes: 60cf46ae6054 ("io-wq: hash dependent work")

but I didn't look too closely yet... Fix looks good, though.

-- 
Jens Axboe