Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 22 Mar 2020 17:37:04 +0000
From:   Jonathan Cameron <jic23@kernel.org>
To:     Mike Looijmans <mike.looijmans@topic.nl>
Cc:     devicetree@vger.kernel.org, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org, knaack.h@gmx.de, lars@metafoo.de,
        pmeerw@pmeerw.net, robh+dt@kernel.org, mark.rutland@arm.com
Subject: Re: [PATCH] dt-bindings: iio: accel: Add bmi088 accelerometer
 bindings
Message-ID: <20200322173704.5cc497c1@archlinux>
In-Reply-To: <20200316065218.4103-1-mike.looijmans@topic.nl>
References: <20200316065218.4103-1-mike.looijmans@topic.nl>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 16 Mar 2020 07:52:18 +0100
Mike Looijmans <mike.looijmans@topic.nl> wrote:

> This adds the device-tree bindings for the Bosch Sensortec BMI088 IMU,
> the accelerometer part.
> 
> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
> ---
>  .../devicetree/bindings/iio/accel/bmi088.txt  | 23 +++++++++++++++++++

Sorry.  All new DT bindings need to be in yaml format.

Please put this in the same series as the driver.

Thanks,

Jonathan

>  1 file changed, 23 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/accel/bmi088.txt
> 
> diff --git a/Documentation/devicetree/bindings/iio/accel/bmi088.txt b/Documentation/devicetree/bindings/iio/accel/bmi088.txt
> new file mode 100644
> index 000000000000..691a47726dbc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/accel/bmi088.txt
> @@ -0,0 +1,23 @@
> +* Bosch BMI088 IMU combining accelerometer and gyroscope
> +
> +https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmi088-ds001.pdf
> +
> +Required properties:
> +
> +  - compatible : should be "bosch,bmi088_accel"
> +  - reg : the I2C address of the sensor or the SPI chip select number
> +
> +Optional properties:
> +
> +  - interrupts : interrupt mapping for GPIO IRQ, it should be configured with
> +		 IRQ_TYPE_EDGE_RISING
> +
> +Example:
> +
> +bmi088_accel@1 {
> +	compatible = "bosch,bmi088_accel";
> +	reg = <1>;
> +	spi-max-frequency = <10000000>;
> +	interrupt-parent = <&gpio>;
> +	interrupts = <90 IRQ_TYPE_EDGE_RISING>;
> +};