Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1584421001-2647-1-git-send-email-Anson.Huang@nxp.com> <86mu89zqce.wl-maz@kernel.org>
In-Reply-To: <86mu89zqce.wl-maz@kernel.org>
From:   Daniel Baluta <daniel.baluta@gmail.com>
Date:   Sun, 22 Mar 2020 21:08:11 +0200
Message-ID: <CAEnQRZCcmaU91Ep5kVesaGPsrvujq5mznk2SZccmZG9rbSCG0w@mail.gmail.com>
Subject: Re: [PATCH] irqchip: irq-imx-gpcv2: Remove unnecessary blank lines
To:     Marc Zyngier <maz@kernel.org>
Cc:     Anson Huang <Anson.Huang@nxp.com>, tglx@linutronix.de,
        jason@lakedaemon.net, Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        dl-linux-imx <Linux-imx@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Mar 21, 2020 at 5:22 PM Marc Zyngier <maz@kernel.org> wrote:
>
> On Tue, 17 Mar 2020 04:56:41 +0000,
> Anson Huang <Anson.Huang@nxp.com> wrote:
> >
> > Remove unnecessary blank lines for cleanup.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > ---
> >  drivers/irqchip/irq-imx-gpcv2.c | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/irqchip/irq-imx-gpcv2.c b/drivers/irqchip/irq-imx-gpcv2.c
> > index 4f74c15..4f11b9b 100644
> > --- a/drivers/irqchip/irq-imx-gpcv2.c
> > +++ b/drivers/irqchip/irq-imx-gpcv2.c
> > @@ -17,7 +17,6 @@
> >  #define GPC_IMR1_CORE2               0x1c0
> >  #define GPC_IMR1_CORE3               0x1d0
> >
> > -
> >  struct gpcv2_irqchip_data {
> >       struct raw_spinlock     rlock;
> >       void __iomem            *gpc_base;
> > @@ -287,6 +286,5 @@ static int __init imx_gpcv2_irqchip_init(struct device_node *node,
> >       of_node_clear_flag(node, OF_POPULATED);
> >       return 0;
> >  }
> > -
> >  IRQCHIP_DECLARE(imx_gpcv2_imx7d, "fsl,imx7d-gpc", imx_gpcv2_irqchip_init);
> >  IRQCHIP_DECLARE(imx_gpcv2_imx8mq, "fsl,imx8mq-gpc", imx_gpcv2_irqchip_init);
>
> I honestly don't think this deserves a patch. Next time you work on
> this driver, add the cleanups to it. But on its own, it's only churn.

While you are technically right, it's only churn I think we need this
for code consistency and cleanup.

Even if we fix this when we work on the driver we still need
to make the cleanup in a separate patch.

My 2 cents,
Daniel.