Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp3035031ybb; Sun, 22 Mar 2020 13:44:35 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvsGNabNANbGOFu8VykxWzcH6BGu+rajhjozxmDU255IuuDZs9a4fDzEcdajiJD1PJy5BZg X-Received: by 2002:aca:310a:: with SMTP id x10mr14273002oix.151.1584909875346; Sun, 22 Mar 2020 13:44:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584909875; cv=none; d=google.com; s=arc-20160816; b=KTT1RnG22zygYKmXLKJznqQVUcgwAuGlxrdIYSqPHCkAFXl8qJpRdnlizWgN/kw6fi KBgDdzkt425eNyajBbB/AQBu7rPzkk+qcYWOvbbBdOc6Z/LQZbnwxvr3IH9bAmtqmlOW OOufKeyEEbuMs2KWGTvxGE9Ml3qVYp0TEqK6HjkCASkfLPwsKG03blM9AD15WqnF9sk9 9fiuom1kJWz3OO2getV/rQTSSFZqDjmMyPv7wMTfMeiD6jrNa9itceo6YiPuB6ZX8Cr7 53XRXmlvNwEz7BXTKqIdPAA7e4c4kvgEqqGQjzVo5SB3EGSgpYu1ujuKNRp9gvGYwpY/ jGMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:dkim-signature; bh=Dz+2Uob3noOGfG/gAkss2I4L8DqttYOljfCofmLgP6A=; b=bzdFnENKQIedDjSL587WqY6MLyQJ4R+vXv72ZjsoxUZ02RlL8A6fbxjyVS0avB2iAB RjTfGaKI00nbuxWqK2sbUNC642R4AiN9/OLQP/wwHfkamd1fDesqmXFVeN7AVJZeH4a7 Cxk45fQ3WOuPffoB94zomYfzHbKSOcSg/rEW4kQDA26bDYvRwPcl3UMYko2eqKunmK4q BKjMFoMlL5zRWG16N7UXDuNeUFggLr/KTvOCXxxRjJ7t5RIjy7eWTzBpknTMrTCx2irm ufrMnbM/uY3nGdMJy2e8DJVEwYGBYbJojohiW4Tzdn9H3O0geAkzFiNvT8NI0rRmApaO +xeQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=t8Uviq3D; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l17si6905711otn.221.2020.03.22.13.44.23; Sun, 22 Mar 2020 13:44:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=t8Uviq3D; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726809AbgCVUmw (ORCPT + 99 others); Sun, 22 Mar 2020 16:42:52 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:43963 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726623AbgCVUmw (ORCPT ); Sun, 22 Mar 2020 16:42:52 -0400 Received: by mail-pl1-f194.google.com with SMTP id v23so925091ply.10; Sun, 22 Mar 2020 13:42:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Dz+2Uob3noOGfG/gAkss2I4L8DqttYOljfCofmLgP6A=; b=t8Uviq3DrjWLRSjqSoikSxiiY1qjZeV7OXGthtYYueOSGggbLk9DK7rgciwX0i57us DpqCUj8xDgXUx1QRxU386MZ16enQt8D3cnWtP8lh3EFxmcX8nmrMEttOCD9ttVIihEXN Zm8WKgKcQgJACTH2lywi5GgynnBIg/L7yoaTNbZl1cKEItDCiC93ZRc170xfLpBHQsQ7 6/Og1Wa4ktQLTkHmuGHQ/m+rMUUwuuHWnACcDW4cFoacqe7tu+L8gLgyVq4HwZW9CeEi tLqhHZ40E9fCRoV2bmlsMrZbd1KS1QUTlK5bKoT6D84XXeA9pX6RBl2HN/eXygRoWVOw ZO4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Dz+2Uob3noOGfG/gAkss2I4L8DqttYOljfCofmLgP6A=; b=p9dsJtiLKIISQK5C2uS6PBBpa5yIAGernfxg70EdnENi4n7HYXn/lc76Yxpj0uvKE+ rZ5x6RgRLHFJz7Woy72uzGrmsLR01DujJvmHxMWWsqJ5Fn1zcrFeSk0teQijKtVfN0KL G8sDdvKRkK9DN37+2HbpFobXW8LxNZw4tHC9erO9cqIhExlpC0inuChTkCvgy+0O4x2y I1P71ztj1LS78PrULoCVB8lwQse4UCIB93aWDiU6RpiQNoQcYdC/o1cHGX/41l0HKSFi Te7HcI+7r9Pyh9k7qCWRjMzejr8xrZP26l1Ph6Av7NCyVMYg3DX4moaef7gbqEA9jDvu gn6Q== X-Gm-Message-State: ANhLgQ2hNHQ65wbjlZ3t9uP87ReeLnDCGFpKc+ci4qgMXcoxaLLcCrMt Qo1UmkkltG8efIu0Mg4hGj5DBSD3 X-Received: by 2002:a17:902:bf4b:: with SMTP id u11mr3963661pls.5.1584909770082; Sun, 22 Mar 2020 13:42:50 -0700 (PDT) Received: from [192.168.1.3] (ip68-111-84-250.oc.oc.cox.net. [68.111.84.250]) by smtp.gmail.com with ESMTPSA id bt19sm1516432pjb.3.2020.03.22.13.42.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Mar 2020 13:42:49 -0700 (PDT) Subject: Re: [PATCH net] ethtool: fix reference leak in some *_SET handlers To: Michal Kubecek , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org Cc: Andrew Lunn , linux-kernel@vger.kernel.org References: <20200322201551.E11BAE0FD3@unicorn.suse.cz> From: Florian Fainelli Autocrypt: addr=f.fainelli@gmail.com; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: <8cb04749-7967-a94f-2bfe-91c3a67a9f78@gmail.com> Date: Sun, 22 Mar 2020 13:42:49 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Firefox/68.0 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200322201551.E11BAE0FD3@unicorn.suse.cz> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/22/2020 1:15 PM, Michal Kubecek wrote: > Andrew noticed that some handlers for *_SET commands leak a netdev > reference if required ethtool_ops callbacks do not exist. A simple > reproducer would be e.g. > > ip link add veth1 type veth peer name veth2 > ethtool -s veth1 wol g > ip link del veth1 > > Make sure dev_put() is called when ethtool_ops check fails. > > Reported-by: Andrew Lunn > Signed-off-by: Michal Kubecek Would not you want a Fixes: tag for this change? Reviewed-by: Florian Fainelli -- Florian