Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp3052097ybb; Sun, 22 Mar 2020 14:12:27 -0700 (PDT) X-Google-Smtp-Source: ADFU+vt5UYy+LsI33z+3OkiiBQS/hkw5hwRrF3G+9Tb0SfMDUCUU/ZSZYbQlk1b8P3AulWl7sGAO X-Received: by 2002:aca:4d47:: with SMTP id a68mr15770769oib.56.1584911547098; Sun, 22 Mar 2020 14:12:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584911547; cv=none; d=google.com; s=arc-20160816; b=vJ0h4SYiznfEaYGpr6CIyTSF6z4tMW6peDwk+kN6By97+Dg01MtSIsi5gkxXtpDi/t 0G8Slz4YQd2zes91ggHgdbDDFnT8d185NqKzWcO8ktOD+dgfmrEptHr3HLwCBEbBxHiq l3GfjLB19be8IqbHrU1L/tRhwRlNchl7cWWZlsz25WPvEPRRQJ5rQcSZCDhA+akIJX7d WNJmHKNjjaIBDFWrAKLflIXLyhXsKfHBrUf4XKX3oWAYEhpBCMgT9JrveZr4GbKtTFjx rCZ3fYgf28OvsrTYCod3crFjQInsE3ZhKTpl9Gzfkqr1ssgh3a8qBrZkvZcTSo5aeb/c ajLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=/qpPXRnqX6Qbrf5cWUtBs0Wf+9ggvdzLfofR4QXh58s=; b=mPj8gaq79ltlewf7ioLcxqD8XsPSguefi9MQTPQOg95DRl+0zOdl7Cdf1AAhzVEDgh ucbPiYKr2UTBAMhgHNL85LUOlXRY9oJkFUolyRLZCshMDCQOe+gL/q1RMm7hYiKO4vft 0VVYo6uWR3Uw9a3MQ5wdqi82sanJoULEJ8WQUes6e9/sx7GxkdV9zsVTXDX53TKcvSkA yXOOXzJhEohV85cQI4Q68X5M/UnR2Pm4s+NfDarVMzBklrso9VjzWOKxsZgzMaqR5Dyo 7prbHh99C61DZWDZiC0lzGmHOKfp4QTWujU46Z82oAf6JTOOCiCbLi+gQYCogDAIFyAI 6LJQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c19si8998369ots.118.2020.03.22.14.12.15; Sun, 22 Mar 2020 14:12:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726816AbgCVVLl (ORCPT + 99 others); Sun, 22 Mar 2020 17:11:41 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:65089 "EHLO relay2-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726741AbgCVVLl (ORCPT ); Sun, 22 Mar 2020 17:11:41 -0400 X-Originating-IP: 86.202.105.35 Received: from localhost (lfbn-lyo-1-9-35.w86-202.abo.wanadoo.fr [86.202.105.35]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 78CFA40002; Sun, 22 Mar 2020 21:11:39 +0000 (UTC) Date: Sun, 22 Mar 2020 22:11:39 +0100 From: Alexandre Belloni To: Anson Huang Cc: a.zummo@towertech.it, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, Linux-imx@nxp.com Subject: Re: [PATCH] rtc: mxc: Use devm_add_action_or_reset() for calls to clk_disable_unprepare() Message-ID: <20200322211139.GC221863@piout.net> References: <1584349785-27042-1-git-send-email-Anson.Huang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1584349785-27042-1-git-send-email-Anson.Huang@nxp.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/03/2020 17:09:45+0800, Anson Huang wrote: > Use devm_add_action_or_reset() for calls to clk_disable_unprepare(), > which can simplify the error handling, and .remove callback can be dropped. > > Signed-off-by: Anson Huang > --- > drivers/rtc/rtc-mxc.c | 46 +++++++++++++++++++--------------------------- > 1 file changed, 19 insertions(+), 27 deletions(-) > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com