Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp3137680ybb; Sun, 22 Mar 2020 16:33:20 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtLZQ6v5x/TGScIpKIZ5o66CIEWV53AQGVQgBdgfn4b9jzkO9fqsKjB88DD3soID5anoRZc X-Received: by 2002:aca:ec49:: with SMTP id k70mr15487756oih.80.1584920000361; Sun, 22 Mar 2020 16:33:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584920000; cv=none; d=google.com; s=arc-20160816; b=B53QS6IeW7rCVDqv4TfN0qVGJayCOqPLFLEjjsAFNKsKBxSvOA79f8p9LiQtI6TxQ6 9t7XaiWMdRcPPvRgkS74Yh1/2x6Q7fnENz6AXWNuh8pxyt6kHtECYX9f3dPLuihCcMZt ex96h6sORkcZI8xaQG+TsS2X2eQHraa8eqkvYUQaZ7pX34PWJ3oDzutVYxx7GP309qnZ CkmTUyQ3lUwkSx1c8dmypgF+2r9JknEzOsJ6eMKaJYmc0Ghf9OpBVvEZhYE1jgSemTH0 E2+1gWLgTfWexMZ6b7L2C88d7/IVOe9A2vMJwGfiJmdtg7GE7N+lg1iJRII8FR3Ly05P 3tRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=IENbMcSGhaQb3ITcGtt42TlCIbqArf7b4nbOoZQxr/0=; b=h/4g/CxncuXOmXnEjK+63QiCk7kfwgkSg6yWuq9VQG+bGCACPNEWHxg7o0YwcxnQqN B7182exQQkY7Y2Dl2sK0xg6qrwUAH3iCF3da4YiSxqmsLuwEW9JlbpXQw0EnJmvC7X8i FeaotJKsQSCqTnp48yTUvb+ZT70YKJ+x8M5Pr9KZWljvIAsh9Q/dQppHAC/e1xGkToBh GAp2ml4ZuhHv2EfnO1lNU16Oi0PdujNp6Yo+OLFbO/jHqgvIjdammGG5kgPsqYbdF4nm w/NijAcMcOY3j4UbsRB+e8Ky/yvJaUaYOqJB2k2YSvKfb18N9M+W6fQ7ah76s+0Dg/kl CtYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=gJZRw8Gh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f129si6700661oia.243.2020.03.22.16.33.05; Sun, 22 Mar 2020 16:33:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=gJZRw8Gh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726880AbgCVXcs (ORCPT + 99 others); Sun, 22 Mar 2020 19:32:48 -0400 Received: from mail-pj1-f68.google.com ([209.85.216.68]:52468 "EHLO mail-pj1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726814AbgCVXcr (ORCPT ); Sun, 22 Mar 2020 19:32:47 -0400 Received: by mail-pj1-f68.google.com with SMTP id ng8so5266684pjb.2; Sun, 22 Mar 2020 16:32:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IENbMcSGhaQb3ITcGtt42TlCIbqArf7b4nbOoZQxr/0=; b=gJZRw8Ghj+uFJGManDNJaEh5tGVtq4ar68g3APlfcnTC/UM62G1dZTEZC9EiOu8x8T EK2Lhb7fOV+nIz8/awxFr3MC6r18K4e/v7mi+9CdZi0d9dsTV7JpA2feKrTgAQ3zSF0e ceB3BcqEO8fMAUdF9bHFlB9wB0nD0uuNeF55tueTktjXIRPtF1crMVSIUmmXbjimo+kX AhZ3ol2geIqX+akPCkQRDT4uFeXHZjfGu2h9E94KPOnSvXuwuqcyuerFu7VfiLWBuCTZ GUkXMilftwjvOnXY7haQAu9G4nVpi6H5ZClCl0D9mPR1H8d3tWvEqj5+4MlinWmCeFLO B/TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IENbMcSGhaQb3ITcGtt42TlCIbqArf7b4nbOoZQxr/0=; b=iwiWMRcWB7OF+abAMsi8/lKFtD7OslBLP7qWx2WUoVuCnvGdXtbMKhZqe6z2QAqHgi 14otWl2qniNSYdDlDQ4rZIjo78URa/cVoBmAk9GgM+/PGN+yq/JMyJ2SpMz1EpQg1nOA ydb82BEkM5HSNR2CXQGOJfmdQfeG3Hg2/XnCAM0l1EftJLaHnlMIBInubJbsChjPY6pt 8CbhqzYVLbEYxGEIEq5C12LNJei2YSuoa1M7yV+Rsxfna0SE7WVV/5hsGmlebfcbJAJH GNZGbGZskyQK3asGWzQk4gCrtXGQLe4bngaM2onpNNqCO1ftUFJjKth11bUcnaAqFCyX 4BNw== X-Gm-Message-State: ANhLgQ2yFCVLTaYOvpxKYjAYOMsHYRgheY8DhCnaApE6DhyfEMv4OBbS RDltNvyhD21hIbQkJuPgWni2N9bhMBvoMp/SbP4= X-Received: by 2002:a17:90a:3602:: with SMTP id s2mr763542pjb.143.1584919965895; Sun, 22 Mar 2020 16:32:45 -0700 (PDT) MIME-Version: 1.0 References: <20200322224626.13160-1-sravanhome@gmail.com> <20200322224626.13160-4-sravanhome@gmail.com> In-Reply-To: <20200322224626.13160-4-sravanhome@gmail.com> From: Andy Shevchenko Date: Mon, 23 Mar 2020 01:32:34 +0200 Message-ID: Subject: Re: [PATCH v4 3/5] iio: adc: mp2629: Add support for mp2629 ADC driver To: Saravanan Sekar Cc: Lee Jones , Rob Herring , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , Sebastian Reichel , devicetree , Linux Kernel Mailing List , linux-iio , Linux PM Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 23, 2020 at 12:47 AM Saravanan Sekar wrote: > > Add support for 8-bit resolution ADC readings for input power > supply and battery charging measurement. Provides voltage, current > readings to mp2629 power supply driver. ... > +#include > +#include Don't see users of it. > +#include > +#include > +#include > +#include Any users? > +#include Perhaps ordered? > +#include > +#include > +#include + blank line? > +#include ... > +static int mp2629_read_raw(struct iio_dev *indio_dev, > + struct iio_chan_spec const *chan, > + int *val, int *val2, long mask) > +{ > + struct mp2629_adc *info = iio_priv(indio_dev); > + unsigned int rval; > + int ret; > + > + switch (mask) { > + case IIO_CHAN_INFO_RAW: > + ret = regmap_read(info->regmap, chan->address, &rval); > + if (ret < 0) > + return ret; > + > + if (chan->address == MP2629_INPUT_VOLT) > + rval &= 0x7f; GENMASK() ? > + *val = rval; > + return IIO_VAL_INT; > + return 0; > +} ... > + void **pdata = pdev->dev.platform_data; Same Qs as per other patch. ... > + indio_dev->dev.of_node = pdev->dev.of_node; Jonathan, doesn't IIO core do this for all? -- With Best Regards, Andy Shevchenko