Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp3197031ybb; Sun, 22 Mar 2020 18:07:18 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuN+xKdCD7jrYxJDqxkk6wXv52wYmgGx7KWks7Pbb0C4O7K995YpsReAGaziWxCR2ZS8ZaI X-Received: by 2002:a9d:220e:: with SMTP id o14mr14945139ota.88.1584925638010; Sun, 22 Mar 2020 18:07:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584925638; cv=none; d=google.com; s=arc-20160816; b=03/NkQJDeBcz1v7ctJJlG7mzErZcQ6x+gTaf+qO5obajUQ/7QAiJupfzyLymWMloJw jvTA3I27CeaQMLo42toYojPrczi4Qw/1BjtYYWAvgeEEW/Y/lkxaJ8gAHWTiHuuaQSNG ZrFPbOKzMeP9ejwK4IC23P6iGBNU0H2cpKt2Sv3zQFdqhItkMYGbTDzFpfoW+qzSyD/T gh3mOpCG3jWLQmXC1t+gxZXGvHW0iEult7JfS8jiQXaYRnWdw9HaRIhZMNYMD1ii/9i8 fOJWVvEVrZLUgWnjEhebyEVUObycwfQqPhI7iCYJeIabdP4cXEmUufdLGchP1Q1bTY8c mC8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=aG1HR6vnX9d/puzieVgxoR5+qeHzgld0YjOlInXM12g=; b=VW2hvGFuS8fh+GHm4MMBVZttKNR+ZTOSyn83quRHMXLQsMXlMWM9Ic2435yYnqvVU/ Tmlkt/t5cX/TKH3mREzjK3JVly3wTgnKKvJAdhsrepw8BUO0Kw4t4R1VxR52CIm9cD5e 59JAPC33uXsKXqwxtHnf9iaYoXRFFPvhtIcnqHY4V4/hh3UqaTbtWkSNYxNLaehw0lIZ YQLYnxSMEfi/Z12Zfoz0zQLpiGlX10mci1C6tqtPrv1csb5CDcufPh0UEe67z1ZEe5m8 lgbTAWjfFhLKuFMaAYrfc4B4CpPcLPVZn6AWECNDQvXSjdCAwBuaHmOjruGRKqal7rec RAVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LD++SuMv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x6si207356oto.92.2020.03.22.18.06.47; Sun, 22 Mar 2020 18:07:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LD++SuMv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726954AbgCWBEp (ORCPT + 99 others); Sun, 22 Mar 2020 21:04:45 -0400 Received: from us-smtp-delivery-74.mimecast.com ([216.205.24.74]:58163 "EHLO us-smtp-delivery-74.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726916AbgCWBEp (ORCPT ); Sun, 22 Mar 2020 21:04:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584925483; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aG1HR6vnX9d/puzieVgxoR5+qeHzgld0YjOlInXM12g=; b=LD++SuMv10RwYBDj1gQIezbJWyURhrso8rcrcNwZmBJcTC454eEXcY+duP3bQmGd0vIzJD wTj/6PwpTmRYPsgwbTMU1hbVJSIiXD0SQNrutBXVSC+crVAsXoe8ISLcPXIwn7P15GzE9S ba0aLQoG/D8Nz9TEZBdjq+2M/un9cFU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-339-gkMjLTdKPYCXVIHRwbB7lA-1; Sun, 22 Mar 2020 21:04:40 -0400 X-MC-Unique: gkMjLTdKPYCXVIHRwbB7lA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 25360107ACCC; Mon, 23 Mar 2020 01:04:38 +0000 (UTC) Received: from elisabeth (unknown [10.40.208.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9E23960BF1; Mon, 23 Mar 2020 01:04:33 +0000 (UTC) Date: Mon, 23 Mar 2020 02:04:25 +0100 From: Stefano Brivio To: Shreeya Patel Cc: Joe Perches , Greg KH , Larry.Finger@lwfinger.net, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH 01/11] Staging: rtl8188eu: hal_com: Add space around operators Message-ID: <20200323020425.62dbeebb@elisabeth> In-Reply-To: References: <19950c71482b3be0dd9518398af85e964f3b66b1.1584826154.git.shreeya.patel23498@gmail.com> <20200322112744.GC75383@kroah.com> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Shreeya, On Mon, 23 Mar 2020 04:48:08 +0530 Shreeya Patel wrote: > On Sun, 2020-03-22 at 08:09 -0700, Joe Perches wrote: > > On Sun, 2020-03-22 at 12:27 +0100, Greg KH wrote: > > Hi Greg and Joe, > > > > On Sun, Mar 22, 2020 at 03:51:13AM +0530, Shreeya Patel wrote: > > > > Add space around operators for improving the code > > > > readability. > > > > Reported by checkpatch.pl > > > > > > > > git diff -w shows no difference. > > > > diff of the .o files before and after the changes shows no > > > > difference. > > > > > > There is no need to have these two lines on every changelog comment > > > in > > > this series :( > > > Yes I get that. > > > In my opinion, there's no need for a series here. > > > > Whitespace only changes _should_ be done all at once. > > > > Whitespace changes _could_ have changed string constants. > > > > So noting that the patch in only whitespace and that > > there isn't a difference in object files is useful as > > it shows any change has been compiled and tested. > > > > Joe, I feel the same thing, there is no need of a patch series > for it but I was given a suggestion that it becomes difficult for the > reviewers to review the patch so it is good to send a patchset instead. In this case, reviewing the 224 lines you're touching in one shot feels the same as reviewing them over 11 patches, as the change is always of the same type. Maybe a single patch is actually even a bit quicker to review. Are you sure the suggestion was referring to this, and it wasn't about different type of changes in the same patch? -- Stefano