Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp3278061ybb; Sun, 22 Mar 2020 20:19:01 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvckpw1R9p2avDzoP8Elvv35WD5mCcYRJgVwIjf4smseh2af/Roo0Vst+XkOaTt8idEPY7j X-Received: by 2002:a05:6830:16d1:: with SMTP id l17mr2078033otr.363.1584933541321; Sun, 22 Mar 2020 20:19:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584933541; cv=none; d=google.com; s=arc-20160816; b=mm1opnw+ctFK4da5ULDfLAO8GN+Z3bbA1ELdvAEawau9OoRv8fhTBAsEoRYqZw8H80 JsMazJ+wDdecT10y7zrRgpVxGMmMQV3+HaSe2lUYbAWp89Zd6fbB08/pRLiKzOURYkn1 RsipJb8+mRxgLovBWaqYLG7j7m1axaC5tipKgzhRCJLQ2+8BbEzYBkZb8uGdq7GuIC7A HIlvPhItl61PBpEKBxwwCnZfqZVqOdi7phiT50/vp2T8dvIWAOGr7OqKJnlv09IzEhPi 6okQw4k273fQpQbSEssqLXWKdDvTe4SKykMlMVNwyA/BVlo2YpcHPEscpOz4Ihy3W9/y YMtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:dkim-signature; bh=ADbIUm07Jo+6o0WZFLpwcGFfQa7iZ4Cd0fx6zgYPrcE=; b=p7o+ctg6BMjOSWbuv/RDUpF2O/Q9NQAN62yVnH1g6Bclf0Ox+/7eigbqMyJvPfDUE9 0AGFFjb4hjHaKO4fTVKfwx4X1Y3ObM9zWjFQdJRZLuvBFHQ8M/mh48VD/adUnyu9hwyF Z5Y60WPqCSz0i9Uyltxh2E9/AXipTOhiwUAAT5zQA9lpOmAY1MFQc1HOotwTlidGUaLw eovsWqc8WDTHzcNWPInjW77wdlNjYHxqLvdEFXMnS7BEIS4/1uOaYkQkq0jUJS+8FXyQ dFt/bd03DIcoe2XsMQCTO67VVWB7TSvlvN+0G6PG5lBnLWWajZxjtCTsMyMCm332Dgb7 Bb0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=GSd8CU4x; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q7si6949779otk.77.2020.03.22.20.18.49; Sun, 22 Mar 2020 20:19:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=GSd8CU4x; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727186AbgCWDRz (ORCPT + 99 others); Sun, 22 Mar 2020 23:17:55 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:37283 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726979AbgCWDRz (ORCPT ); Sun, 22 Mar 2020 23:17:55 -0400 Received: by mail-wr1-f68.google.com with SMTP id w10so15201513wrm.4; Sun, 22 Mar 2020 20:17:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ADbIUm07Jo+6o0WZFLpwcGFfQa7iZ4Cd0fx6zgYPrcE=; b=GSd8CU4xIgZTbRom4yNM0u0nYg8ZNSgGsedl5NQLSk5EpnbkpcU/afXPMjB9WPXIL+ cRnsXo4QvRVNtbOIt4P9k5a6WyrSFEbyOAW1QMhDhoCJe+gqOwJibDwEiC3nnCx3vze0 2ehY1aA1o4vDtLpXGmagerNQJYUw2iqJSgFFq5M4WvEjTTWqbO0O7Xz+LUqpv7zlc1e3 Ckq8nRSFELORWjOORxTUib8qcY+LvE2LJFHM2g8Sl4fv1CrRrqMd8afDmE++G4eMDROK TXWMMZkuTNYpeJOfbmtchf+1xDmAvbs3c4nZg4qzYfa8EpCkR6hPehYEAwciSBs2D/7D QqPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=ADbIUm07Jo+6o0WZFLpwcGFfQa7iZ4Cd0fx6zgYPrcE=; b=GsY/tqJ3algSB+7d1VSDCh5YvAloUb5FANpIANTgQyKtFUwwA5J5kQsLXxfuEdTVUP U0Dfrl3TJ0B4tBWDFRVp6vSzC5TlihDbNTbkFfIuB8M9kinydc6oJPEcrNbZzcuZ0gL5 NXlnhmaojFWt88waZ3Ww20As4RF3BhsPqfUOgdZQyRAXryHkPIh+FQK0aljpTeV83li1 6aMkietNOYUbqwNShS83L4wHR+/4b2MU0mbq1S3Txzrib4yvOnfKdfI0CmKfZ2fUIV8a 9JPvue57FgR+vDV3Pz9185esIJLITJr0t3x/eTAge1BTJ9B9syiapdubIESiDOYDrjLP /X/g== X-Gm-Message-State: ANhLgQ1hAzHR2IBaQ1GFrjs0nvA1JaP93XrJ2Ho1LfuElIo+bRhiWOPC RxexlVNsWxWMNFcPD/HRksXf90OA X-Received: by 2002:adf:90ee:: with SMTP id i101mr26498989wri.417.1584933472045; Sun, 22 Mar 2020 20:17:52 -0700 (PDT) Received: from [10.230.186.223] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id f10sm21366023wrw.96.2020.03.22.20.17.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Mar 2020 20:17:51 -0700 (PDT) Subject: Re: [PATCH net-next v6 09/10] net: phy: smsc: use phy_read_poll_timeout() to simplify the code To: Dejin Zheng , andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, mchehab+samsung@kernel.org, gregkh@linuxfoundation.org, broonie@kernel.org, tglx@linutronix.de, netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org References: <20200323025633.6069-1-zhengdejin5@gmail.com> <20200323025633.6069-10-zhengdejin5@gmail.com> From: Florian Fainelli Autocrypt: addr=f.fainelli@gmail.com; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: <50e68879-adf3-52f4-1b0b-334dd02ef85a@gmail.com> Date: Sun, 22 Mar 2020 20:17:47 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Firefox/68.0 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200323025633.6069-10-zhengdejin5@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/22/2020 7:56 PM, Dejin Zheng wrote: > use phy_read_poll_timeout() to replace the poll codes for > simplify lan87xx_read_status() function. > > it should be add msleep(10) before call phy_read_poll_timeout() > to keep the code more similar, but it will report that warning, so > modify it to msleep(20). > > ./scripts/checkpatch.pl > v5-0009-net-phy-smsc-use-phy_read_poll_timeout-to-simplif.patch > WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst > #42: FILE: drivers/net/phy/smsc.c:126: > + msleep(10); > > Suggested-by: Andrew Lunn > Signed-off-by: Dejin Zheng Reviewed-by: Florian Fainelli -- Florian