Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1584938972-7430-1-git-send-email-iamjoonsoo.kim@lge.com>
 <1584938972-7430-3-git-send-email-iamjoonsoo.kim@lge.com> <20200323052145.GD3039@MiWiFi-R3L-srv>
 <20200323054037.GI2987@MiWiFi-R3L-srv>
In-Reply-To: <20200323054037.GI2987@MiWiFi-R3L-srv>
From:   Joonsoo Kim <js1304@gmail.com>
Date:   Mon, 23 Mar 2020 14:58:15 +0900
Message-ID: <CAAmzW4O-c23H8ogAwhkM97GEeCKgxGtPx7v+csSTikEq7nH82A@mail.gmail.com>
Subject: Re: [PATCH v4 2/2] mm/page_alloc: integrate classzone_idx and high_zoneidx
To:     Baoquan He <bhe@redhat.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Linux Memory Management List <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Michal Hocko <mhocko@kernel.org>,
        Minchan Kim <minchan@kernel.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        Mel Gorman <mgorman@techsingularity.net>, kernel-team@lge.com,
        Ye Xiaolong <xiaolong.ye@intel.com>,
        David Rientjes <rientjes@google.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

2020=EB=85=84 3=EC=9B=94 23=EC=9D=BC (=EC=9B=94) =EC=98=A4=ED=9B=84 2:40, B=
aoquan He <bhe@redhat.com>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1:
> > > diff --git a/include/trace/events/compaction.h b/include/trace/events=
/compaction.h
> > > index e5bf6ee..54e5bf0 100644
> > > --- a/include/trace/events/compaction.h
> > > +++ b/include/trace/events/compaction.h
> > > @@ -314,40 +314,44 @@ TRACE_EVENT(mm_compaction_kcompactd_sleep,
> > >
> > >  DECLARE_EVENT_CLASS(kcompactd_wake_template,
> > >
> > > -   TP_PROTO(int nid, int order, enum zone_type classzone_idx),
> > > +   TP_PROTO(int nid, int order, enum zone_type highest_zoneidx),
> > >
> > > -   TP_ARGS(nid, order, classzone_idx),
> > > +   TP_ARGS(nid, order, highest_zoneidx),
> > >
> > >     TP_STRUCT__entry(
> > >             __field(int, nid)
> > >             __field(int, order)
> > > -           __field(enum zone_type, classzone_idx)
> > > +           __field(enum zone_type, highest_zoneidx)
> > >     ),
> > >
> > >     TP_fast_assign(
> > >             __entry->nid =3D nid;
> > >             __entry->order =3D order;
> > > -           __entry->classzone_idx =3D classzone_idx;
> > > +           __entry->highest_zoneidx =3D highest_zoneidx;
> > >     ),
> > >
> > > +   /*
> > > +    * classzone_idx is previous name of the highest_zoneidx.
> > > +    * Reason not to change it is the ABI requirement of the tracepoi=
nt.
> > > +    */
> > >     TP_printk("nid=3D%d order=3D%d classzone_idx=3D%-8s",
> >                                  ~~~~~~~~~~ this one could be missed.
>
> Oh, I realized above 'classzone_idx=3D%-8s' being kept is for the old
> script compatibility? then it's OK.

Yes, this is for userspace compatibility. There are two places that aren't
changed due to compatibility and they are commented on top of the line.

Thanks.

> >
> > And I applied this patch series, use 'git grep classzone_idx' to search
> > any relics, found below classzone_idx leftover in perl script.
> > [~]$ git grep classzone_idx
> > Documentation/trace/postprocess/trace-vmscan-postprocess.pl:my $regex_l=
ru_isolate_default =3D 'isolate_mode=3D([0-9]*) classzone_idx=3D([0-9]*) or=
der=3D([0-9]*) nr_requested=3D([0-9]*) nr_scanned=3D([0-9]*) nr_skipped=3D(=
[0-9]*) nr_taken=3D([0-9]*) lru=3D([a-z_]*)';
> > Documentation/trace/postprocess/trace-vmscan-postprocess.pl:           =
         "isolate_mode", "classzone_idx", "order",