Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp3376964ybb; Sun, 22 Mar 2020 23:08:18 -0700 (PDT) X-Google-Smtp-Source: ADFU+vv2v0ADgf+7oz4eDQsgniwZOAR6nO6tyys9DHXYX2y0uLZs7xtP4AQUB9vgESgrcyLDTNS0 X-Received: by 2002:a9d:7488:: with SMTP id t8mr4896476otk.219.1584943698430; Sun, 22 Mar 2020 23:08:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584943698; cv=none; d=google.com; s=arc-20160816; b=zkLes8/sbcUP0GzxJvfkmX5QSLNfj3oX/Rn9EeYnBkFcglYwOvLvVb7hOS0kfyLJxL ZAbFEI+iuqSkWj1nQ1HDihc0mwMAumkjF9uFxaClOst2irmbbYs47ClSxNmpeEUk/cVv heCAfx1540mYgKqdbduCCWAusszuoSL+thtI6iMapoyU30DpdvonOW+x48JdTMxPtcmm +qkArZE2EUtVANBJd9mrYBYcnsUG+sAQpovBeW7vOrRwCIyaqhhuDRth3oEwxdRKDU59 0NDkmp4G3TepAQa1Muo8Ps3MQQzV6w1h97V8rxvLmS3dlG1isWbgwt++I0PNcUTRyUyn w1Mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=EnunS0Dmo+0aJ/S19O1D9kWbu/oJIdFkRq0mnlu2pRs=; b=Ho4CY8qQ/3LLSdRQv4Mocaw6hbjyg0g0iyuAVlLixRlPApUo9byJwF6HhuX3C7vyg7 3jb9LScrDiKyS3Rk1XdQ1McSkVXhEhMcMg7vJ8CoXRtbsnGS13+AGMoPPOmzeeSkeVyl DM67d3VYmQJ8xhksdTyV7K0kAMAifpjkJi6VcdBadVBlKp/NxdCL+Kqyuk0AH0Cp7c+C 1/8VdVb8IrhrB9t9jPYg56GqY3sZau414r1U5x/0uzyH8PSjUJIH0ECWrnS02uw0tbfp lOrMiLEOBUdnMHsQgpQ+oAwlJV4DRaqWUS7bm3ihX1iakUu9MB03gy0WT5Mp+Knqjmu2 3xoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=T+AKXtTi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h4si7076259otk.87.2020.03.22.23.08.04; Sun, 22 Mar 2020 23:08:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=T+AKXtTi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727264AbgCWGHS (ORCPT + 99 others); Mon, 23 Mar 2020 02:07:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:44026 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726142AbgCWGHS (ORCPT ); Mon, 23 Mar 2020 02:07:18 -0400 Received: from localhost (unknown [171.76.96.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0DD4C206C3; Mon, 23 Mar 2020 06:07:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584943637; bh=ibPYCWGXC+3W4pwXBMCDZLajjZQWIs4y9VSQ1PY2kkE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T+AKXtTiEx2F4fvV576lTkypnagA0PkvNzMXSxvZCfsQ+YIHsqHbXosnbB9ZvN8mv F3NhqdKp08F1Skw1MDp4NuKvE1w/xHqo5uPtiVFbcDk/CGoTaa649qlUQdGtAiFLc6 oPfZ4DmvrU+yToy7LBmg3A4VuQ+ng8ms2q+SF7Jg= Date: Mon, 23 Mar 2020 11:37:13 +0530 From: Vinod Koul To: Baolin Wang Cc: dan.j.williams@intel.com, orsonzhai@gmail.com, zhang.lyra@gmail.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: sprd: Set request pending flag when DMA controller is active Message-ID: <20200323060713.GC72691@vkoul-mobl> References: <02adbe4364ec436ec2c5bc8fd2386bab98edd884.1584019223.git.baolin.wang7@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <02adbe4364ec436ec2c5bc8fd2386bab98edd884.1584019223.git.baolin.wang7@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12-03-20, 21:26, Baolin Wang wrote: > From: Zhenfang Wang > > On new Spreadtrum platforms, when the CPU enters idle, it will close > the DMA controllers' clock to save power if the DMA controller is not > busy. Moreover the DMA controller's busy signal depends on the DMA > enable flag and the request pending flag. > > When DMA controller starts to transfer data, which means we already > set the DMA enable flag, but now we should also set the request pending > flag, in case the DMA clock will be closed accidentally if the CPU > can not detect the DMA controller's busy signal. Applied, thanks -- ~Vinod