Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp3518547ybb; Mon, 23 Mar 2020 02:36:30 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvt9prNgNydZbknzfEoZE1MEq82JRPniiJt+g24594MBKF/gKJeqQet6ePF9HtJb2ScIQHC X-Received: by 2002:a9d:6e90:: with SMTP id a16mr17262176otr.72.1584956190841; Mon, 23 Mar 2020 02:36:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584956190; cv=none; d=google.com; s=arc-20160816; b=BohdsoN88nllee3jpHVt1Qg3jVh33Z/OmMmi6tqyyZUz5h0i73IkVEbbpigqh6CTIQ yBktSy1zGpb7paB6oFb5/ZxELKRSFwWbQ8RO/awy30BKeTH9uaM9hc7l5h+mMSrP+ABf 9io54wRHpWZ447uKC+MwKKCmA5fQtcJG2VWJzqvuebPN5px/+s9cpW2fW7zRJpUxdd8T bSe6aLeu8+R4cWzUJLGkxrI88f60iE2YOpl0FZikyvRLRF6UCHfY+Ks8kYkqduC7f9pn Qwj01Mub1zAgL0WEe12kwSBucNHmI8kY492c10qFxeDaFT6gYw81qY5chwm+HUFRqVmJ tZXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=5aiBOd50YmyoZIpq8Mzd85bWQsf70Eq/EDFcc64IO90=; b=heJNIyinNuiikQeeWb32F7cGCFRtLQF512hpFR6JDzUv6FUaB35VVmbABl39eieCRU dralavySvBe8/zPzAIpf81ErcxmREzDHZGU3E0UrlgWkzuGrMijP6dSRhRq+E8YwFzNf 60wbwLDDldyre83jft/LqHECkqzwDjxerBOyQL04vEdci9gkIVPS9jmkckUaqWrffCV8 bJStFELAH1vxDsLwEmC6+jJyOq2k+Z/N54lGIcJX+eHaYJRE3R4tCJOiGEo3FFV7mmMr CpjmglwKPgwcnFICMKSdy001IOb/evuykdF7ephPhDMFbKwWrUxStxwi4O5V+XJN5pQF fyIA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n82si6726746oib.123.2020.03.23.02.36.16; Mon, 23 Mar 2020 02:36:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727732AbgCWJfY (ORCPT + 99 others); Mon, 23 Mar 2020 05:35:24 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:44747 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727695AbgCWJfY (ORCPT ); Mon, 23 Mar 2020 05:35:24 -0400 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jGJUO-0003Th-GA; Mon, 23 Mar 2020 10:35:20 +0100 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1jGJUN-0002CU-Fr; Mon, 23 Mar 2020 10:35:19 +0100 Date: Mon, 23 Mar 2020 10:35:19 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Rayagonda Kokatanur Cc: Thierry Reding , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Yendapally Reddy Dhananjaya Reddy , linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] pwm: bcm-iproc: handle clk_get_rate() return Message-ID: <20200323093519.krno3znzqbptrwxj@pengutronix.de> References: <20200323092424.22664-1-rayagonda.kokatanur@broadcom.com> <20200323092424.22664-2-rayagonda.kokatanur@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200323092424.22664-2-rayagonda.kokatanur@broadcom.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 23, 2020 at 02:54:23PM +0530, Rayagonda Kokatanur wrote: > Handle clk_get_rate() returning <= 0 condition to avoid > possible division by zero. The idea I wanted to transport with my question about how this problem was found is that the commit log is amended with this information. This is important information as it helps people having to decide if this change should be backported. Also it would be great to know if this can really make the kernel crash or if (e.g.) said clock cannot be off in practise. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | https://www.pengutronix.de/ |