Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
References: <20200320151245.21152-1-mgorman@techsingularity.net> <20200320151245.21152-3-mgorman@techsingularity.net>
User-agent: mu4e 0.9.17; emacs 26.3
From:   Valentin Schneider <valentin.schneider@arm.com>
To:     Mel Gorman <mgorman@techsingularity.net>
Cc:     Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Phil Auld <pauld@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] sched/fair: Track efficiency of task recent_used_cpu
In-reply-to: <20200320151245.21152-3-mgorman@techsingularity.net>
Date:   Mon, 23 Mar 2020 13:30:25 +0000
Message-ID: <jhj1rpjmc5q.mognet@arm.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On Fri, Mar 20 2020, Mel Gorman wrote:
> SIS Recent Used Hit: A recent CPU was eligible and used. Each hit is
>       a domain search avoided.
>
> SIS Recent Used Miss: A recent CPU was eligible but unavailable. Each
>       time this is hit, there was a penalty to the fast path before
>       a domain search happened.
>
> SIS Recent Success Rate: A percentage of the number of hits versus
>       the total attempts to use the recent CPU.
>
> SIS Recent Attempts: The total number of times the recent CPU was examined.
>       A high number of Recent Attempts with a low Success Rate implies
>       the fast path is being punished severely. This could have been
>       presented as a weighting of hits and misses but calculating an
>       appropriate weight for misses is problematic.
>

Ditto on the raw vs post-processed detail in the changelog, otherwise:

Reviewed-by: Valentin Schneider <valentin.schneider@arm.com>

> Signed-off-by: Mel Gorman <mgorman@techsingularity.net>