Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932339AbWBUR6S (ORCPT ); Tue, 21 Feb 2006 12:58:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932345AbWBUR6S (ORCPT ); Tue, 21 Feb 2006 12:58:18 -0500 Received: from [81.2.110.250] ([81.2.110.250]:14546 "EHLO lxorguk.ukuu.org.uk") by vger.kernel.org with ESMTP id S932339AbWBUR6R (ORCPT ); Tue, 21 Feb 2006 12:58:17 -0500 Subject: Re: [ PATCH 2.6.16-rc3-xen 3/3] sysfs: export Xen hypervisor attributes to sysfs From: Alan Cox To: "Mike D. Day" Cc: xen-devel@lists.xensource.com, lkml , Greg KH , Dave Hansen In-Reply-To: <43FB2642.7020109@us.ibm.com> References: <43FB2642.7020109@us.ibm.com> Content-Type: text/plain Content-Transfer-Encoding: 7bit Date: Tue, 21 Feb 2006 18:02:03 +0000 Message-Id: <1140544923.840.28.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 (2.2.3-2.fc4) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 419 Lines: 13 Last time I checked sizeof(char) was 1 so the kcalloc sizeof(char) is excessive and we als have kzalloc() which would be slightly cleaner. Otherwise looks sane to me Alan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/