Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp3828901ybb; Mon, 23 Mar 2020 08:25:56 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuy1k6EKaHxlHuEt53lpMf7jyp3PKUPFS6+L66SG8XnUzLAvwcu2uorG154xS/FuNaNSQwb X-Received: by 2002:a9d:22e9:: with SMTP id y96mr18179161ota.217.1584977156622; Mon, 23 Mar 2020 08:25:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584977156; cv=none; d=google.com; s=arc-20160816; b=f8EAmYkJn164rCZZg4nO+8VzlMHJNt7AHtpKWu3bZBXCX0k7i18yIDGEuoWtCCNqaO QbtH2ZYi8ZO0tkRU869ghkl0X3kd3O0M5lN/PetxyyYOhnUnWVjAlCCCVbDX88fCEl+x j0szg+R49gCBNw/NhUfKqHT5CprkpTh2PNp8bunyFmp5g7sg3Z8plYbrJtFRgVAK4Tnj vZJnZ8aSDgDTCpzNTgPt2GasJ3Bh3VlNmwCEYSCy+aWOSeux5VyNf1ZdfK+Ja/RDd6eJ R1mZKm2U8f1LjkJSMdHkx4mWwHCh33WDE/qNf+uqQuV2RsJsjNrH3hn8FQaIh+Sgy5RE dFQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:in-reply-to :subject:cc:to:from:date; bh=w9gzduVWxO3kR++gNzIHRZYsUqh4diAvAeirLzXpAAE=; b=yUsDs2jYqmKx8zoJ8IDJzDGe+1jO01SI3jTeyjzgEZipgqmbp4St2KoS9aXkcnc+Fg PQOeDxV4ZjlQZ3jdewtRBVKXPRDNIIxpr98awgt+JgjhIdeKbfQZWCEBWQ4aqJ8NAVEy iogCr6Uw3h6doMtU0EKGkRgt6mZ5gDc0MElTtJeZcx8MTs5kTGMcoxxcP6bK98OtKwNr lAReqAXFSjmlWwx4lm+8LEGkm7iX+8Qg8xk77Qmrj4UC/4Xr/flqCoDfOLnad0P5SoeA 0PEecVv6l5bpRdAQ2SwsCAnSzWK/ataUYDExJJ2JGMsmTmUqQcVfzY6ZXvaf6xOpK+ly 9OOw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y52si7231737otb.191.2020.03.23.08.25.43; Mon, 23 Mar 2020 08:25:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727260AbgCWPZO (ORCPT + 99 others); Mon, 23 Mar 2020 11:25:14 -0400 Received: from netrider.rowland.org ([192.131.102.5]:59027 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1727228AbgCWPZO (ORCPT ); Mon, 23 Mar 2020 11:25:14 -0400 Received: (qmail 24985 invoked by uid 500); 23 Mar 2020 11:25:13 -0400 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 23 Mar 2020 11:25:13 -0400 Date: Mon, 23 Mar 2020 11:25:13 -0400 (EDT) From: Alan Stern X-X-Sender: stern@netrider.rowland.org To: Vinod Koul cc: Mathias Nyman , Greg Kroah-Hartman , , Bjorn Andersson , Yoshihiro Shimoda , Christian Lamparter , John Stultz , =?UTF-8?q?Andreas=20B=C3=B6hler?= , , , Mathias Nyman Subject: Re: [PATCH v7 1/5] usb: hci: add hc_driver as argument for usb_hcd_pci_probe In-Reply-To: <20200323101121.243906-2-vkoul@kernel.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 23 Mar 2020, Vinod Koul wrote: > usb_hcd_pci_probe expects users to call this with driver_data set as > hc_driver, that limits the possibility of using the driver_data for > driver data. > > Add hc_driver as argument to usb_hcd_pci_probe and modify the callers > ehci/ohci/xhci/uhci to pass hc_driver as argument and freeup the > driver_data used > > Tested xhci driver on Dragon-board RB3, compile tested ehci and ohci. > Couldn't compile uhci > > Suggested-by: Mathias Nyman > Signed-off-by: Vinod Koul > --- > drivers/usb/core/hcd-pci.c | 7 ++++--- > drivers/usb/host/ehci-pci.c | 6 ++---- > drivers/usb/host/ohci-pci.c | 9 ++++++--- > drivers/usb/host/uhci-pci.c | 8 ++++++-- > drivers/usb/host/xhci-pci.c | 14 +++++--------- > include/linux/usb/hcd.h | 3 ++- > 6 files changed, 25 insertions(+), 22 deletions(-) For all but the xHCI parts: Acked-by: Alan Stern