Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1584977769.27949.18.camel@suse.de>
Subject: Re: lockdep warning in urb.c:363 usb_submit_urb
From:   Oliver Neukum <oneukum@suse.de>
To:     Qais Yousef <qais.yousef@arm.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org
Date:   Mon, 23 Mar 2020 16:36:09 +0100
In-Reply-To: <20200323143857.db5zphxhq4hz3hmd@e107158-lin.cambridge.arm.com>
References: <20200323143857.db5zphxhq4hz3hmd@e107158-lin.cambridge.arm.com>
Content-Type: multipart/mixed; boundary="=-IYg+DkhohS1dh6vva5Gj"
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--=-IYg+DkhohS1dh6vva5Gj
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

Am Montag, den 23.03.2020, 14:38 +0000 schrieb Qais Yousef:
> Hi
> 
> I've hit the following lockdep warning when I trigger hibernate on arm64
> platform (Juno-r2)
> 
> 
> 	echo suspend > /sys/power/disk
> 	echo disk > /sys/power/state
> 
> I only had a usb flash drive attached to it. Let me know if you need more info.

Hi,

that is not a lockdep issue, but the hub driver is not properly killing
its URB presumably. Yet, the driver looks correct to me. Please use
the additional patch and activate dynamic debugging for usbcore.

	Regards
		Oliver

--=-IYg+DkhohS1dh6vva5Gj
Content-Disposition: attachment; filename="0001-usb-hub-additional-debugging.patch"
Content-Type: text/x-patch; name="0001-usb-hub-additional-debugging.patch";
	charset="UTF-8"
Content-Transfer-Encoding: base64

RnJvbSA4MzU3ZDlkN2FiZTM1ZDVlMzY4NGY1MTI3ZmVhNmQyNDMwMDExNTI2IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBPbGl2ZXIgTmV1a3VtIDxvbmV1a3VtQHN1c2UuY29tPgpEYXRl
OiBNb24sIDIzIE1hciAyMDIwIDE2OjM0OjM1ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gdXNiOiBo
dWIgYWRkaXRpb25hbCBkZWJ1Z2dpbmcKCi0tLQogZHJpdmVycy91c2IvY29yZS9odWIuYyB8IDEg
KwogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy91
c2IvY29yZS9odWIuYyBiL2RyaXZlcnMvdXNiL2NvcmUvaHViLmMKaW5kZXggNTRjZDhlZjc5NWVj
Li4yNTUzMGNmMzAzODEgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvdXNiL2NvcmUvaHViLmMKKysrIGIv
ZHJpdmVycy91c2IvY29yZS9odWIuYwpAQCAtMTYyOSw2ICsxNjI5LDcgQEAgc3RhdGljIGludCBo
dWJfY29uZmlndXJlKHN0cnVjdCB1c2JfaHViICpodWIsCiAJCXJldCA9IC1FTk9NRU07CiAJCWdv
dG8gZmFpbDsKIAl9CisJZGV2X2RiZyhodWJfZGV2LCAiJXAgVVJCIGFsbG9jYXRlZCBcbiIpOwog
CiAJdXNiX2ZpbGxfaW50X3VyYihodWItPnVyYiwgaGRldiwgcGlwZSwgKmh1Yi0+YnVmZmVyLCBt
YXhwLCBodWJfaXJxLAogCQlodWIsIGVuZHBvaW50LT5iSW50ZXJ2YWwpOwotLSAKMi4xNi40Cgo=


--=-IYg+DkhohS1dh6vva5Gj--