Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 0/2] io-uring: cleanup: drop completion upon removal of
 file
To:     Hillf Danton <hdanton@sina.com>
Cc:     syzbot <syzbot+538d1957ce178382a394@syzkaller.appspotmail.com>,
        io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com,
        viro@zeniv.linux.org.uk
References: <20200323092419.8764-1-hdanton@sina.com>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <5f98097a-b3f7-fc8f-4a84-f848253a0e56@kernel.dk>
Date:   Mon, 23 Mar 2020 09:57:25 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <20200323092419.8764-1-hdanton@sina.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 3/23/20 3:24 AM, Hillf Danton wrote:
> 
> Kudos to the task hung reported by syzbot, and inspired by it, cleanup
> is made for dropping completion when files are removed from the fixed
> fileset. Another cleanup is also proposed for dropping the done field
> in struct io_file_put.
> 
> [PATCH 1/2] io_uring: drop completion when removing file
> [PATCH 2/2 RFC] io-uring: drop done in struct io_file_put

I like it - I applied, only changing 'done' to 'free_pfile' to make it
more apparent what it controls. Thanks!

-- 
Jens Axboe