Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 23 Mar 2020 10:29:54 -0700
From:   Davidlohr Bueso <dave@stgolabs.net>
To:     oneukum@suse.com
Cc:     linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        Davidlohr Bueso <dbueso@suse.de>
Subject: Re: [PATCH 7/8] usb, cdc-acm: optimize barrier usage for Rmw atomic
 bitops
Message-ID: <20200323172954.pyxw5v4pmuvkbjrp@linux-p48b>
References: <20200129181545.25302-1-dave@stgolabs.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20200129181545.25302-1-dave@stgolabs.net>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

ping? Can these please be picked up?

On Wed, 29 Jan 2020, Davidlohr Bueso wrote:

>We can avoid the unnecessary barrier on non LL/SC architectures,
>such as x86. Instead, use the smp_mb__after_atomic() call.
>
>Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
>---
> drivers/usb/class/cdc-acm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
>index 62f4fb9b362f..0bc4b558f387 100644
>--- a/drivers/usb/class/cdc-acm.c
>+++ b/drivers/usb/class/cdc-acm.c
>@@ -842,7 +842,7 @@ static void acm_tty_unthrottle(struct tty_struct *tty)
> 	clear_bit(ACM_THROTTLED, &acm->flags);
>
> 	/* Matches the smp_mb__after_atomic() in acm_read_bulk_callback(). */
>-	smp_mb();
>+	smp_mb__after_atomic();
>
> 	acm_submit_read_urbs(acm, GFP_KERNEL);
> }
>-- 
>2.16.4
>