Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp3966546ybb; Mon, 23 Mar 2020 11:00:14 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtrk28bzH4Sdf1cBISpYnFMYQ0SZ6XaJp2KamiJbTcTun6dfbmi2QLlnEiI4ywCstYi6okl X-Received: by 2002:a4a:b90e:: with SMTP id x14mr757565ooo.34.1584986414083; Mon, 23 Mar 2020 11:00:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584986414; cv=none; d=google.com; s=arc-20160816; b=dqEavrB34grPEjIlbd5Y0pZ5cTIag86GiBdfBvJCnHL9m6g1SnU8UNaNxpHpuiEtDn 8OAn+5q+AOkpLimJVAcSmQl9XFb6uxPcvu6IMzWAE96gCAb1xQ4OlnWiFYre+UDHIaJ+ vEz2ITm5l1fCT0AuDH6Pc8voL8H4IAdxn1KPv8E4L1sacyDq85ovTDj/CVsCdcvsoBjL p7BIrt+UBEIRmV1w236U3UusDm6sHKV/7e485CcvXgmP+cRre31Q5Oko78hqAO/tWwW5 teA6a5++988mYzaApbHkXt25TZOBqp0MnQ8nlup5LFY8bZQpgP3/rrHRLacFkbmRTTL3 5g4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=2l0KQW4VoP61cJLv+dL28Z9ly7A7laSQG5Iu1ELGiNg=; b=SWwLnNHd/IZEHRjrz2lWhCs0ld39eqYsOXuVf1WoeTO4Q0nikHs49Q68PpoTVtnuBj eiJ/PUtrr84jP0z61BYUK0v9FJOIcmS3fwA3h9GLS95FYHGJ94QHN5c/rypYmpeFnMnz wB7oMC8O0Nvn9Q1IhTCmKN9eFicl5czMWmbQ5SwfUgnZsoJTcZ31/lGKDbeUgQvsk4sd 3KobtCH5Satp3o6A4jjU83Uyx+eL8F5AEdpiXxKFCLWDaWmURoG0atXlB9jKJsX5rRMi JHj+IuIuRAzhvZNM4mMgPv/1/a9dTQu7cgnqLg758E5IeRfeZelLug69lFDdXOTvXEDb k2Ng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=0lqsb+hy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z23si247165oos.54.2020.03.23.10.59.59; Mon, 23 Mar 2020 11:00:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=0lqsb+hy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727364AbgCWR7b (ORCPT + 99 others); Mon, 23 Mar 2020 13:59:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:35396 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727011AbgCWR7b (ORCPT ); Mon, 23 Mar 2020 13:59:31 -0400 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6C2292076E; Mon, 23 Mar 2020 17:59:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584986370; bh=2l0KQW4VoP61cJLv+dL28Z9ly7A7laSQG5Iu1ELGiNg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=0lqsb+hyuD6XqDBK/iujiOzptPXvHe2aV/Kkwr/P9PUnDfHuueev3+9fAESyrBbXO ZkqqYSoJFuvUWkikxGH/IUJ026YcMeuNlg4tvEn2RHdNtA8m0Q8d/1izBjP/Y7z1YM neW0n8jo8z3fJdmpYEmC19DdPkIw8QyaG/UxJ2uQ= Received: by mail-qk1-f173.google.com with SMTP id x3so4743764qki.4; Mon, 23 Mar 2020 10:59:30 -0700 (PDT) X-Gm-Message-State: ANhLgQ3X6lkENw1D+18PwfR1dHlvEp+svbIONC0IFdXeaX3lh/nmGMJ+ CfwV5SOwBn319i1jyWmcJbwatv4y65OE6frLzg== X-Received: by 2002:a37:8502:: with SMTP id h2mr22475590qkd.223.1584986369516; Mon, 23 Mar 2020 10:59:29 -0700 (PDT) MIME-Version: 1.0 References: <20200320174107.29406-1-lkundrak@v3.sk> <20200320174107.29406-9-lkundrak@v3.sk> In-Reply-To: <20200320174107.29406-9-lkundrak@v3.sk> From: Rob Herring Date: Mon, 23 Mar 2020 11:59:17 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 08/10] powerpc/fsl: Make serial ports compatible with ns16550a To: Lubomir Rintel Cc: Greg Kroah-Hartman , Mark Rutland , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Marc Gonzalez , Mans Rullgard , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , linuxppc-dev , "open list:SERIAL DRIVERS" , "linux-kernel@vger.kernel.org" , devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 20, 2020 at 11:41 AM Lubomir Rintel wrote: > > There are separate compatible strings for ns16550 and ns16550a and the > Freescale serial port is compatible with the latter one, with working > FIFO. I don't think changing this is right. First, 'ns16550' is what's documented in the DT spec (and ePAPR which it's based on). Second, these dts files are pretty mature/stable, so I'm less inclined to change them. AFAICT, this change either enables the fifo (which would be an untested change in behavior) or has no effect because the fifo is auto-detected. > Use the appropriate compatible string that is also consistent with ARM64 > Freescale boards and thus avoiding one special case in the binding schema. Well, that's annoying... Rob