From: Andi Kleen <ak@suse.de>
To: Greg KH <greg@kroah.com>
Subject: Re: [PATCH 3/6] PCI legacy I/O port free driver (take2) - Add device_flags into pci_device_id
Date: Tue, 21 Feb 2006 21:59:51 +0100
User-Agent: KMail/1.8.2
Cc: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>,
       linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz,
       akpm@osdl.org, rmk+lkml@arm.linux.org.uk
References: <43FAB283.8090206@jp.fujitsu.com> <43FAB375.2020007@jp.fujitsu.com> <20060221205640.GA12423@kroah.com>
In-Reply-To: <20060221205640.GA12423@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200602212159.52106.ak@suse.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 797
Lines: 23

On Tuesday 21 February 2006 21:56, Greg KH wrote:

> I don't think you can add fields here, after the driver_data field.  It
> might mess up userspace tools a lot, as you are changing a userspace
> api.

User space should look at the ASCII files (modules.*), not the binary
As long as the code to generate these files still works it should be ok.

> Do you _really_ need to pass this information back from userspace to the
> driver in this manner?

Well driver_data wouldn't be needed then either. Obviously it's for more
than just userspace.

-Andi

 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/