Date: Tue, 21 Feb 2006 13:01:32 -0800
From: Greg KH <greg@kroah.com>
To: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz,
       akpm@osdl.org, ak@suse.de, rmk+lkml@arm.linux.org.uk
Subject: Re: [PATCH 1/6] PCI legacy I/O port free driver (take2) - Add no_ioport flag into pci_dev
Message-ID: <20060221210132.GA12436@kroah.com>
References: <43FAB283.8090206@jp.fujitsu.com> <43FAB2F1.5030106@jp.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <43FAB2F1.5030106@jp.fujitsu.com>
User-Agent: Mutt/1.5.11
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 752
Lines: 20

On Tue, Feb 21, 2006 at 03:28:01PM +0900, Kenji Kaneshige wrote:
> -	if (pci_resource_flags(pdev, bar) & IORESOURCE_IO)
> +	if (pci_resource_flags(pdev, bar) & IORESOURCE_IO) {
> +		WARN_ON(pdev->no_ioport);

You might want to just print out a nicer warning to the user through the
syslog, using dev_warn() otherwise they are not going to know which
device and driver are having problems.

Also, people see the output of this, and think their kernel just died,
which is not the case here.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/