Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200323173653.41305-1-brendanhiggins@google.com>
 <e5f7db19-4468-8679-9ed1-3565a0adcfc0@kernel.org> <CAFd5g46GqBqdrRk6743bnUQyS+yStP3DpkVNWsAMEHDS3i3FBw@mail.gmail.com>
In-Reply-To: <CAFd5g46GqBqdrRk6743bnUQyS+yStP3DpkVNWsAMEHDS3i3FBw@mail.gmail.com>
From:   Brendan Higgins <brendanhiggins@google.com>
Date:   Mon, 23 Mar 2020 12:24:50 -0700
Message-ID: <CAFd5g44R6yTQENSsS+LSnQppzO=gDVfPB-TxLn_+aT8UpLiTcQ@mail.gmail.com>
Subject: Re: [PATCH v1] kunit: tool: add missing test data file content
To:     shuah <shuah@kernel.org>
Cc:     David Gow <davidgow@google.com>,
        Heidi Fahim <heidifahim@google.com>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        KUnit Development <kunit-dev@googlegroups.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Mar 23, 2020 at 12:15 PM Brendan Higgins
<brendanhiggins@google.com> wrote:
>
> On Mon, Mar 23, 2020 at 11:44 AM shuah <shuah@kernel.org> wrote:
> >
> > On 3/23/20 11:36 AM, Brendan Higgins wrote:
> > > A test data file for one of the kunit_tool unit tests was missing; add
> > > it in so that unit tests can run properly.
> > >
> > > Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
> > > ---
> > > Shuah, this is a fix for a broken test. Can you apply this for 5.7?
> >
> > Can you please add more details on what kind of data this file supplies
> > and which test fails if it doesn't exist.
>
> Sure,
>
> This adds a raw dmesg test log to test the kunit_tool's dmesg parser.
> test_prefix_poundsign and test_output_with_prefix_isolated_correctly
> fail without this test log.
>
> I will send a new revision with this information in the commit message.

I just sent a new revision with an updated message.