Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200323192236.70152-1-brendanhiggins@google.com>
In-Reply-To: <20200323192236.70152-1-brendanhiggins@google.com>
From:   David Gow <davidgow@google.com>
Date:   Mon, 23 Mar 2020 19:56:03 -0700
Message-ID: <CABVgOSkf58zMRhpqoZY3cZuAfujnTwVe14xOMcS6VBC4S2+vEw@mail.gmail.com>
Subject: Re: [PATCH v2] kunit: tool: add missing test data file content
To:     Brendan Higgins <brendanhiggins@google.com>
Cc:     Shuah Khan <shuah@kernel.org>, Heidi Fahim <heidifahim@google.com>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        KUnit Development <kunit-dev@googlegroups.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Mar 23, 2020 at 12:22 PM Brendan Higgins
<brendanhiggins@google.com> wrote:
>
> Add a missing raw dmesg test log to test the kunit_tool's dmesg parser.
> test_prefix_poundsign and test_output_with_prefix_isolated_correctly
> fail without this test log.
>
> Signed-off-by: Brendan Higgins <brendanhiggins@google.com>

Tested-by: David Gow <davidgow@google.com>

This patch does indeed fix the kunit_tool's unit tests (run with
./tools/testing/kunit/kunit_tool_test.py).

Beforehand, it failed with the errors below:
======================================================================
ERROR: test_prefix_poundsign (__main__.KUnitParserTest)
----------------------------------------------------------------------
Traceback (most recent call last):
 File "./tools/testing/kunit/kunit_tool_test.py", line 208, in
test_prefix_poundsign
   self.assertEqual('kunit-resource-test', result.suites[0].name)
IndexError: list index out of range

======================================================================
FAIL: test_output_with_prefix_isolated_correctly
(__main__.KUnitParserTest)
----------------------------------------------------------------------
Traceback (most recent call last):
 File "./tools/testing/kunit/kunit_tool_test.py", line 116, in
test_output_with_prefix_isolated_correctly
   self.assertContains('TAP version 14\n', result)
 File "./tools/testing/kunit/kunit_tool_test.py", line 96, in
assertContains
   str(needle) + '" not found in "' + str(haystack) + '"!')
AssertionError: "TAP version 14
" not found in "<generator object isolate_kunit_output at 0x7f4e88d85ed0>"!

----------------------------------------------------------------------
Ran 20 tests in 0.022s

FAILED (failures=1, errors=1)