Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp4414223ybb; Mon, 23 Mar 2020 21:01:00 -0700 (PDT) X-Google-Smtp-Source: ADFU+vs9rdNQwKQRSRm3vCKgL0Wmz6pEEOeORU1gR2ACoiPSZWxwwZoDItaWPJaevYBb143wsqkx X-Received: by 2002:a05:6830:19a:: with SMTP id q26mr891458ota.285.1585022459820; Mon, 23 Mar 2020 21:00:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585022459; cv=none; d=google.com; s=arc-20160816; b=C6eCNl2GCX3JzfOWhriFEb6SyAlTWMFx875XKQCMQ84RW3DgBYrTAhOivIunLHkztQ V1wNpgXgWr0D93cqwar09UKxiJFwmufb4D1JCeCAE0zH6Dwx6pX/ewvQOhN4yWWoduFf v0khgaGYXl4gFHL47d8eRhKHH1uOXTLfR2r63norfo6pNaJ1dP8p92fdeesOmoWI4VwJ sMKSivR0mCjxbZISu2REzIL0rYLAkeIH9PGG45VancvNmSj+eU1kl6u4St4h1de9UFD6 7pAgAAr24V8kgIpJoDrKveWip26zpbMxa7tOjh1pnZmIL92L47vqtz+9mQhsKyPqqXze JNzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=kPMBIodNCcoGPHuz6RTrNPgzxaUXhJpZToPKqwfLEu0=; b=akdhmvEfNbTkY2CDVXrtSKsmpVSdgtG5ZlxRSyLHitCFa63N3KOWY+8/K4Gm8axVij tthwq5IR8pHUxxi5+zBvAE1UyRxo5O2q6WyvqiVOTUDehlRn/BoiUsrwE6l1JOH8s4Mv FhC2BW5S+ViVdXbP8Q/AzxJtvP2e1JpvZx2wUS/SEJv3si0za+EJIbWJs+HvrIDZZ2Tc 7eX2aruGIbmuwa+2MAW4MY8caLMwz5K43PVYczM6o69A34Ol3Bd2OB84GrGKacFZzYwy ufsKjNs332x38rQ1yAu2KWh4aSnemVWliFkgyogmEux1KGxci8YVY9PIFo+E2/949T7g n88g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y65si8260432oie.92.2020.03.23.21.00.46; Mon, 23 Mar 2020 21:00:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725873AbgCXEA3 (ORCPT + 99 others); Tue, 24 Mar 2020 00:00:29 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:55878 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725784AbgCXEA3 (ORCPT ); Tue, 24 Mar 2020 00:00:29 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id F380E15433174; Mon, 23 Mar 2020 21:00:27 -0700 (PDT) Date: Mon, 23 Mar 2020 21:00:26 -0700 (PDT) Message-Id: <20200323.210026.2188935498095960390.davem@davemloft.net> To: cai@lca.pw Cc: alexander.h.duyck@linux.intel.com, kuznet@ms2.inr.ac.ru, kuba@kernel.org, yoshfuji@linux-ipv6.org, dsahern@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ipv4: fix a RCU-list lock in inet_dump_fib() From: David Miller In-Reply-To: <20200320025421.9216-1-cai@lca.pw> References: <20200320025421.9216-1-cai@lca.pw> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 23 Mar 2020 21:00:28 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Qian Cai Date: Thu, 19 Mar 2020 22:54:21 -0400 > There is a place, > > inet_dump_fib() > fib_table_dump > fn_trie_dump_leaf() > hlist_for_each_entry_rcu() > > without rcu_read_lock() will trigger a warning, > > WARNING: suspicious RCU usage ... > Fixes: 18a8021a7be3 ("net/ipv4: Plumb support for filtering route dumps") > Signed-off-by: Qian Cai Applied and queued up for -stable, thank you.