Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp4516382ybb; Mon, 23 Mar 2020 23:40:15 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvETYahGwswoXfkNZIkVqyjWThHpieAp9Dk//GVDg20igeQLQj3d3LrbcU4j7L5IRBLnfcp X-Received: by 2002:a05:6808:aa8:: with SMTP id r8mr2277293oij.78.1585032015412; Mon, 23 Mar 2020 23:40:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585032015; cv=none; d=google.com; s=arc-20160816; b=zBUTqEY6XTnbCUXtyQYMdywVaIrWCf7b0ICk919CWP5VEaET3NlXV14lGh3ASHm3Fl YixBxHwbMXC94Jf7rpHI5HiycGy+AyLpZ0KLYytgLdF34xjTm7HTu4PdBVEdUG9hy3Er VPN9UETIW3wHQUs2f2zW0MTcbcYqIuiZBiyFX1bNImtpMLwrD2oMDxjheJ9MiByRZoB0 2b0fDwNcwkuCyHXxJRLpZASvSmnUgzgOS63Q1fmS3Kv3RdzZiiT1cD8+v1MpckMpfxWM To6B3l0IKhI1Vgdmh2cQcgntJ3x79HwHgbMBFQ3zUMvZTxDJgoTYNClile9LjF9yP5Tv X/nA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:message-id:date:cc:to:from:subject:dkim-signature; bh=DOHGkNP9wh1iO1J5OIkX8CL+OdPnCkXwDuHeEIAWHT0=; b=QGKdtQh4hMvCJiqkuwuYqrMB/xvwmpenL9fWK1njX5igpc2lrktvMHf3Aag0ZpS7m5 lc1Ofs8m+R4wowYR/uwml0zH9+LFRU5WraAKZ3ixqz9ZLDGTPXdtVLJc/NzGU5w9zvgS UFqX9Sz1f1SOLrPQGIQScjbWFAJc0iXm9tLNwn4PlLzAkHDhGGkWsIKHiumMTtwQMEGB a+yZQICaH46Hrc6BttH2TRh/sAIiGGVaqeZULNjKjMqyT0oSMBGucGw78M81TpZpt7Ve jGK/1MGG3+3gIy6mDXcauZcBXnyeWDoit75GChh6pvKK9qKCKUM9x6D57QcBVAy5HK5p siYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@yandex-team.ru header.s=default header.b=JSTt9akt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=yandex-team.ru Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d20si8751446oti.311.2020.03.23.23.40.01; Mon, 23 Mar 2020 23:40:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@yandex-team.ru header.s=default header.b=JSTt9akt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=yandex-team.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727298AbgCXGjm (ORCPT + 99 others); Tue, 24 Mar 2020 02:39:42 -0400 Received: from forwardcorp1j.mail.yandex.net ([5.45.199.163]:45004 "EHLO forwardcorp1j.mail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725867AbgCXGjm (ORCPT ); Tue, 24 Mar 2020 02:39:42 -0400 Received: from mxbackcorp1j.mail.yandex.net (mxbackcorp1j.mail.yandex.net [IPv6:2a02:6b8:0:1619::162]) by forwardcorp1j.mail.yandex.net (Yandex) with ESMTP id 89E032E132A; Tue, 24 Mar 2020 09:39:39 +0300 (MSK) Received: from myt5-70c90f7d6d7d.qloud-c.yandex.net (myt5-70c90f7d6d7d.qloud-c.yandex.net [2a02:6b8:c12:3e2c:0:640:70c9:f7d]) by mxbackcorp1j.mail.yandex.net (mxbackcorp/Yandex) with ESMTP id vElDNcnrnr-ddNSsLOn; Tue, 24 Mar 2020 09:39:39 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1585031979; bh=DOHGkNP9wh1iO1J5OIkX8CL+OdPnCkXwDuHeEIAWHT0=; h=Message-ID:Date:To:From:Subject:Cc; b=JSTt9aktxoPRYRmgSYFdRM5tFN6PKg+ZRu3ARvNyAM97e7Ov0AgQuUcLOSMVBIiwq hzQSIG+dVrhQDphHO6d+jH2NavydF21wKHdQYH/lNe13KhIbFj5EiZPmouxcQm18jE rdJlOqStlp1n+DBUT7ZTwn65PGeEgOU4qhY72GjQ= Authentication-Results: mxbackcorp1j.mail.yandex.net; dkim=pass header.i=@yandex-team.ru Received: from unknown (unknown [2a02:6b8:b080:6410::1:2]) by myt5-70c90f7d6d7d.qloud-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id LXCZcZNDPq-dcbO1YeB; Tue, 24 Mar 2020 09:39:38 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) Subject: [PATCH v3 0/3] block/diskstats: more accurate io_ticks and optimization From: Konstantin Khlebnikov To: linux-block@vger.kernel.org, Jens Axboe , linux-kernel@vger.kernel.org Cc: Mikulas Patocka , Mike Snitzer , Ming Lei Date: Tue, 24 Mar 2020 09:39:38 +0300 Message-ID: <158503038812.1955.7827988255138056389.stgit@buzz> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Simplified estimation for io_ticks introduced in patch https://lore.kernel.org/linux-block/20181206164122.2166-5-snitzer@redhat.com/ could be very inaccurate for request longer than jiffy (i.e. any HDD) There is at least one another report about this: https://lore.kernel.org/linux-block/20200324031942.GA3060@ming.t460p/ See detail in comment for first patch. v1: https://lore.kernel.org/lkml/155413438394.3201.15211440151043943989.stgit@buzz/ v2: https://lore.kernel.org/lkml/158314549775.1788.6529015932237292177.stgit@buzz/ v3: * update documentation * rebase to current linux-next * fix compilation for CONFIG_SMP=n --- Konstantin Khlebnikov (3): block/diskstats: more accurate approximation of io_ticks for slow disks block/diskstats: accumulate all per-cpu counters in one pass block/diskstats: replace time_in_queue with sum of request times Documentation/admin-guide/iostats.rst | 5 ++- block/bio.c | 9 ++--- block/blk-core.c | 5 +-- block/genhd.c | 64 +++++++++++++++++++++++++-------- block/partition-generic.c | 39 ++++++++++++-------- include/linux/genhd.h | 14 +++++-- 6 files changed, 90 insertions(+), 46 deletions(-) -- Signature