Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 24 Mar 2020 09:35:50 +0100
From:   Morten Rasmussen <morten.rasmussen@arm.com>
To:     Valentin Schneider <valentin.schneider@arm.com>
Cc:     linux-kernel@vger.kernel.org, mingo@kernel.org,
        peterz@infradead.org, vincent.guittot@linaro.org,
        dietmar.eggemann@arm.com
Subject: Re: [RFC PATCH 1/3] sched/topology: Split out SD_* flags declaration
 to its own file
Message-ID: <20200324083550.GE6103@e123083-lin>
References: <20200311183320.19186-1-valentin.schneider@arm.com>
 <20200311183320.19186-2-valentin.schneider@arm.com>
 <20200323134234.GD6103@e123083-lin>
 <jhjy2rrknfb.mognet@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <jhjy2rrknfb.mognet@arm.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Mar 23, 2020 at 05:10:00PM +0000, Valentin Schneider wrote:
> 
> Hi Morten,
> 
> Just as a heads-up, I think those changes would better fit 2/3, or be
> in their own patch. 1/3 is just a straight up code move, with no changes
> to the existing comments.

I realized that when I got to 2/3, and yes, most of the comments are not
really related to your proposal it more things we could fix while we are
touching that code anyway.

> On Mon, Mar 23 2020, Morten Rasmussen wrote:
> > On Wed, Mar 11, 2020 at 06:33:18PM +0000, Valentin Schneider wrote:
> >> +/* Domain members share power domain */
> >> +SD_FLAG(SD_SHARE_POWERDOMAIN,   7)
> >
> > This flag is set only by 32-bit arm and has never had any effect. I
> > think it was the beginning of something years ago that hasn't
> > progressed. Perhaps we can remove it now?
> >
> 
> Right, I don't think I've seen anything recent that uses that flag.

AFAIK, it has never been used, only set.

Morten