Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200324041920.GA7068@asgard.redhat.com>
In-Reply-To: <20200324041920.GA7068@asgard.redhat.com>
From:   Vladimir Oltean <olteanv@gmail.com>
Date:   Tue, 24 Mar 2020 10:55:55 +0200
Message-ID: <CA+h21hrB6JUcM87Lv_V-gMdyVOCncJ9yhRmtVGgWt6eB0MhSow@mail.gmail.com>
Subject: Re: [PATCH net-next] taprio: do not use BIT() in TCA_TAPRIO_ATTR_FLAG_*
 definitions
To:     Eugene Syromiatnikov <esyr@redhat.com>
Cc:     lkml <linux-kernel@vger.kernel.org>,
        netdev <netdev@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Voon Weifeng <weifeng.voon@intel.com>,
        "Dmitry V. Levin" <ldv@altlinux.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Eugene,

On Tue, 24 Mar 2020 at 06:19, Eugene Syromiatnikov <esyr@redhat.com> wrote:
>
> BIT() macro definition is internal to the Linux kernel and is not
> to be used in UAPI headers; replace its usage with the _BITUL() macro
> that is already used elsewhere in the header.
>
> Cc: <stable@vger.kernel.org> # v5.4+
> Fixes: 9c66d1564676 ("taprio: Add support for hardware offloading")
> Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com>
> ---

I see this mirrors what was done in commit

commit 9903c8dc734265689d5770ff28c84a7228fe5890
Author: Vedang Patel <vedang.patel@intel.com>
Date:   Tue Jun 25 15:07:13 2019 -0700

    etf: Don't use BIT() in UAPI headers.

    The BIT() macro isn't exported as part of the UAPI interface. So, the
    compile-test to ensure they are self contained fails. So, use _BITUL()
    instead.

    Signed-off-by: Vedang Patel <vedang.patel@intel.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>

so

Acked-by: Vladimir Oltean <vladimir.oltean@nxp.com>

>  include/uapi/linux/pkt_sched.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/uapi/linux/pkt_sched.h b/include/uapi/linux/pkt_sched.h
> index bbe791b..0e43f67 100644
> --- a/include/uapi/linux/pkt_sched.h
> +++ b/include/uapi/linux/pkt_sched.h
> @@ -1197,8 +1197,8 @@ enum {
>   *       [TCA_TAPRIO_ATTR_SCHED_ENTRY_INTERVAL]
>   */
>
> -#define TCA_TAPRIO_ATTR_FLAG_TXTIME_ASSIST     BIT(0)
> -#define TCA_TAPRIO_ATTR_FLAG_FULL_OFFLOAD      BIT(1)
> +#define TCA_TAPRIO_ATTR_FLAG_TXTIME_ASSIST     _BITUL(0)
> +#define TCA_TAPRIO_ATTR_FLAG_FULL_OFFLOAD      _BITUL(1)
>
>  enum {
>         TCA_TAPRIO_ATTR_UNSPEC,
> --
> 2.1.4
>

Regards,
-Vladimir