Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp4647788ybb; Tue, 24 Mar 2020 02:40:23 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsin2rfB/AHELeW98z94SJJ54MDYivW78M3gr6eGKmljaOPA3V12Ggb//bYeSK24tTBqutu X-Received: by 2002:a05:6830:314e:: with SMTP id c14mr22123663ots.7.1585042822859; Tue, 24 Mar 2020 02:40:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585042822; cv=none; d=google.com; s=arc-20160816; b=IfPU+l0zTPJjHjLlIogurMVU/x0ykCqSnD5+BdzAG9mX97Y+y9w225aZ/ctCVayTam PlDPzCsAbhWz/PrYRdtTti53sem6ANtUw0j4wYqx+7dbfqlJUDCBKp4YlhlBO6j/866p ISTYcPEEk433XSS/Ihc6xZ35c1rMuHpCRP3lwf34T5oYaV9R9Vfa8g0CQDb0hqAfvV9q zoSyNeg8G6Ys0kT+jSi3bSAtkDs+ln2a8toBOyo1/958e4rI3Fqn14/2V5IK0cWoKr5B 3n5v5jdRHbspw76e/FnrkHpMDMhGZHcpdNLk+qJH8BuSvA1lMo+WFjV6wlh2TJgkCIon vDHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=3pd/eJRSpOtFudPhzMppa9zs/wB0k7qIhj2pDE/X6Vs=; b=W76XoMY20cw+Wg//qjxy0vkjZB0DaWO76k+E+/PyIuQmzn03XAU8KTmgf/OISC6Hp7 5gU5F008TNLfQxCZPSpqaARGkzUxriK6pGSXOEMYW7C02si4178+25dh2SIIRohFZT5j EQjD2bqyLJdN6qkLqOhL/qrwCFI/uoJc4xNR1jrwigQfEO7B/TxxzuBgfN5WOuFWF4bo MABDCHHM0v3wnYUui1UW6Q5fE8MHqKp+lNDnqhFOjX71a6aDRZ1GoPR4pNdbE5uTF0kL 5NWsb51JZS9tXC8LgN70MX4W1Jr7YGf5SRS756bopL4Q9naBgXK/9gjDAOT6vnJRqXCJ TmBA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c20si3558279otp.46.2020.03.24.02.40.09; Tue, 24 Mar 2020 02:40:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726944AbgCXJjy (ORCPT + 99 others); Tue, 24 Mar 2020 05:39:54 -0400 Received: from lucky1.263xmail.com ([211.157.147.135]:38112 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726129AbgCXJjx (ORCPT ); Tue, 24 Mar 2020 05:39:53 -0400 Received: from localhost (unknown [192.168.167.8]) by lucky1.263xmail.com (Postfix) with ESMTP id 91F036BAB9; Tue, 24 Mar 2020 17:39:39 +0800 (CST) X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ADDR-CHECKED4: 1 X-ANTISPAM-LEVEL: 2 X-ABS-CHECKED: 0 Received: from localhost.localdomain (unknown [58.22.7.114]) by smtp.263.net (postfix) whith ESMTP id P24779T140190699988736S1585042779131734_; Tue, 24 Mar 2020 17:39:40 +0800 (CST) X-IP-DOMAINF: 1 X-UNIQUE-TAG: X-RL-SENDER: david.wu@rock-chips.com X-SENDER: wdc@rock-chips.com X-LOGIN-NAME: david.wu@rock-chips.com X-FST-TO: netdev@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 X-System-Flag: 0 From: David Wu To: netdev@vger.kernel.org Cc: davem@davemloft.net, kuba@kernel.org, joabreu@synopsys.com, alexandre.torgue@st.com, peppe.cavallaro@st.com, linux-kernel@vger.kernel.org, David Wu Subject: [RFC,PATCH 1/2] netdevice: Add netif_tx_lock_q Date: Tue, 24 Mar 2020 17:38:27 +0800 Message-Id: <20200324093828.30019-1-david.wu@rock-chips.com> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It is similar to netif_tx_lock, but only locks one queue, so it seems to be suitable for multiple queues. If the current queue status is frozen, it will requeue skb, which will not block the current thread, it improve performance when tested. Signed-off-by: David Wu --- include/linux/netdevice.h | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index b6fedd54cd8e..30054a94210e 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -4085,6 +4085,16 @@ static inline void netif_tx_lock(struct net_device *dev) } } +static inline void netif_tx_lock_q(struct netdev_queue *txq) +{ + int cpu; + + cpu = smp_processor_id(); + __netif_tx_lock(txq, cpu); + set_bit(__QUEUE_STATE_FROZEN, &txq->state); + __netif_tx_unlock(txq); +} + static inline void netif_tx_lock_bh(struct net_device *dev) { local_bh_disable(); @@ -4108,6 +4118,12 @@ static inline void netif_tx_unlock(struct net_device *dev) spin_unlock(&dev->tx_global_lock); } +static inline void netif_tx_unlock_q(struct netdev_queue *txq) +{ + clear_bit(__QUEUE_STATE_FROZEN, &txq->state); + netif_schedule_queue(txq); +} + static inline void netif_tx_unlock_bh(struct net_device *dev) { netif_tx_unlock(dev); -- 2.19.1