Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <0336a046563a3d0556c988a67be2642194831710.camel@collabora.com>
Subject: Re: [PATCH 2/2] media: Remove VIDEO_DEV unneeded dependency
From:   Ezequiel Garcia <ezequiel@collabora.com>
To:     Mauro Carvalho Chehab <mchehab@kernel.org>
Cc:     linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        Tomasz Figa <tfiga@chromium.org>,
        Nicolas Dufresne <nicolas@ndufresne.ca>, kernel@collabora.com,
        Hans Verkuil <hverkuil@xs4all.nl>, Sean Young <sean@mess.org>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Sakari Ailus <sakari.ailus@iki.fi>,
        Michael Ira Krufky <mkrufky@gmail.com>,
        Helen Koike <helen.koike@collabora.com>
Date:   Tue, 24 Mar 2020 07:18:49 -0300
In-Reply-To: <20200324104722.1c605792@coco.lan>
References: <20200323211022.28297-1-ezequiel@collabora.com>
         <20200323211022.28297-3-ezequiel@collabora.com>
         <20200324104722.1c605792@coco.lan>
Organization: Collabora
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.0-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 2020-03-24 at 10:47 +0100, Mauro Carvalho Chehab wrote:
> Em Mon, 23 Mar 2020 18:10:22 -0300
> Ezequiel Garcia <ezequiel@collabora.com> escreveu:
> 
> > Enable VIDEO_DEV (which compiles Video4Linux core)
> > when MEDIA_SUPPORT is selected. This is needed, in order
> > to be able to enable devices such as stateless codecs.
> > 
> > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> > ---
> >  drivers/media/Kconfig | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
> > index b36a41332867..7de472ad07a2 100644
> > --- a/drivers/media/Kconfig
> > +++ b/drivers/media/Kconfig
> > @@ -93,13 +93,11 @@ source "drivers/media/mc/Kconfig"
> >  
> >  #
> >  # Video4Linux support
> > -#	Only enables if one of the V4L2 types (ATV, webcam, radio) is selected
> >  #
> >  
> >  config VIDEO_DEV
> >  	tristate
> >  	depends on MEDIA_SUPPORT
> > -	depends on MEDIA_CAMERA_SUPPORT || MEDIA_ANALOG_TV_SUPPORT || MEDIA_RADIO_SUPPORT || MEDIA_SDR_SUPPORT
> >  	default y
> >  
> >  config VIDEO_V4L2_SUBDEV_API
> 
> The rationale of the above is to exclude Digital TV and remote
> controller.
> 
> Removing the above will make the V4L2 core available every time, even
> if all the user wants is remote controller or Digital TV support.
> 

Hm, right.

> I'm working on a patchset that should hopefully address the issues
> you're concerning.
> 

Thanks, I'll appreciate that.

Ezequiel