Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp4680588ybb; Tue, 24 Mar 2020 03:21:20 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuKdwxxZYn+4N7RcmGhYwv8fHW0BbT2iBw++JbuhlTobo5jXQCJHtRpfYG8I7Ts0h5GgbQ+ X-Received: by 2002:aca:5596:: with SMTP id j144mr2913728oib.62.1585045280758; Tue, 24 Mar 2020 03:21:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585045280; cv=none; d=google.com; s=arc-20160816; b=K3gEP8x2xh8Neu7U4I92SCR+ptktAaAWkjKky/jMFSIAJRIfMVl10eg5iky8Vr9Zji 6FLu9/FeyV6OR9uS1E+k4GfjwyW23u7V4tyf7D/VJyWt9TZLC3+caFR3HNuF/67gs9Ik mH12tUqXgc7T+bEVIizZNzIO5xJq7go5Uio3T42Cs1Yn06t1+TXfeC10cXND1cpOMWg7 1rHhrCw7AOP6+YtQ+IX+/aWZSXn9Fm5NG4H7HGx69HikNvax/lJMDaoKLKIGHUMoURpj MHHiPvNGJb+QrNBEbFzsYNTn3Es3iqii+yVvqtdsIOIoCUkhwJGn4cLXSQszNbVDlWYs K8aQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=RHjJI7aShrh91OoV00QHF3f8tRyA7jklYuLyoaLdZpU=; b=daoKCcgX1ilqP7Ds2+A2PRo4cX8V/7JSp1LCD+JwjMTLU/6EE+4A2qBGznntch7szp 4+9HahJwkx7HH7HPTFZlWIi4KIMLBTv7ykOypG10frJm6jH8guIu0OeJGS0wGcm6LbPe lzaXJLZmyK4wfC4RCIP8k3ekOa2VWUlgSXdeKFV5AhVJw2QFpU7mwUJ+1aC0vW7gMNG4 ElmP6IajoweegjGlM6hp9FXBfXRpqXp7txOVeup6Ja14P67ozAw4ixdV9Ha+guVGJOzp SVx8tPgFhNRbrIjjgU66V7TwKAr5BsW7n8zMhBtzgf5ClstgoB04I2n+WUuj+D1CYmrz nT6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=VJDW48n7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w23si9353702oti.18.2020.03.24.03.21.07; Tue, 24 Mar 2020 03:21:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=VJDW48n7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727354AbgCXKUn (ORCPT + 99 others); Tue, 24 Mar 2020 06:20:43 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:36864 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727223AbgCXKUl (ORCPT ); Tue, 24 Mar 2020 06:20:41 -0400 Received: by mail-wr1-f66.google.com with SMTP id w10so20719255wrm.4 for ; Tue, 24 Mar 2020 03:20:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=RHjJI7aShrh91OoV00QHF3f8tRyA7jklYuLyoaLdZpU=; b=VJDW48n7k0ddcp7+Y1+gejwqC9PsCLrSpTZ/9jdmEwACaw5iwrnqY806ZRC+0OlwO9 3oC8uo/6CWdGg+WAI7bBQjVzQPiPbD1gJXoVYQzvIWBqoKIC7qs0YkR5FtIlMd4ZH2b9 hMdrR/e2DLI3EPdIi7aTE21K50ivfVFcRs/B2/NcPsJAr8QRdAS0h6PIQ3X9RpKu54/c YFCeYN464ihgX9YzRe/YLyMSIIdXkA667q6ZD40Yh7ra5keHqkPffOV7DjDwW9Uiw2kb 6ExvPUJv7i4DwgeoJGoKN88gGVoxBWoJtTRDlwDFJ3etJaGoP0zemtbE81+TExeKzoQS wSlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=RHjJI7aShrh91OoV00QHF3f8tRyA7jklYuLyoaLdZpU=; b=TTnGDXgamqmutKOpuOw9E1WH1aT8kHbNx1dhlPtgHboQOs9blbUXC26oFFzI/JA1OG QGygfUfyffliHxJxgoMyhy5VeiAIPI2Rv+fXALp1/oJC4uWYdf29mBsnqpF7v0stFXwY O0bCWCxP+98wsJzdKwMlNvZVvcddDDCbN+U3f1+Ap4lpJ5m7ogQUMCnxraaJrg27KxC0 EojwpYKlaEfn9J33i5cM9GyLQjs2MTzJ95jvbwU9+66D4a0wTUKHyH5EPBNTXY8rA4pr cu/kQck6AxzTR4T76kiOmsq6ma/aheC85xMLadtBl8ecylHwDoL+RExwu8p5LbqPLmJQ JbbQ== X-Gm-Message-State: ANhLgQ3Jb+wE3SmzdJvOjhUtMXt9TAdqvk0dqq4XjAFAB3DYpW1abRTp xvxuvpKpMrJ1lmrACVzvsq6uOA== X-Received: by 2002:adf:efc9:: with SMTP id i9mr15183022wrp.23.1585045238251; Tue, 24 Mar 2020 03:20:38 -0700 (PDT) Received: from bender.baylibre.local ([2a01:e35:2ec0:82b0:5c5f:613e:f775:b6a2]) by smtp.gmail.com with ESMTPSA id h5sm2879527wro.83.2020.03.24.03.20.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2020 03:20:37 -0700 (PDT) From: Neil Armstrong To: kishon@ti.com, balbi@kernel.org, khilman@baylibre.com, martin.blumenstingl@googlemail.com Cc: Neil Armstrong , linux-amlogic@lists.infradead.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 00/13] usb: dwc3: meson: add OTG support for GXL/GXM Date: Tue, 24 Mar 2020 11:20:17 +0100 Message-Id: <20200324102030.31000-1-narmstrong@baylibre.com> X-Mailer: git-send-email 2.22.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The USB support was initialy done with a set of PHYs and dwc3-of-simple because the architecture of the USB complex was not understood correctly at the time (and proper documentation was missing...). But with the G12A family, the USB complex was correctly understood and implemented correctly. But seems the G12A architecture was derived for the GXL USB architecture, with minor differences and looks we can share most of the USB DWC3 glue driver. This patchset refactors and adds callbacks to handle the architecture difference while keeping the main code shared. The main difference is that on GXL/GXM the USB2 PHY control registers are mixed with the PHY registers (we already handle correctly), and the GLUE registers are allmost (99%) the same as G12A. But, the GXL/GXM HW is buggy, here are the quirks : - for the DWC2 controller to reset correctly, the GLUE mux must be switched to peripheral when the DWC2 controlle probes. For now it's handled by simply switching to device when probing the subnodes, but it may be not enough - when manually switching from Host to Device when the USB port is not populated (should not happen with proper Micro-USB/USB-C OTG switch), it makes the DWC3 to crash. The only way to avoid that is to use the Host Disconnect bit to disconnect the DWC3 controller from the port, but we can't recover the Host functionnality unless resetting the DWC3 controller. This bit is set when only manual switch is done, and a warning is printed on manual switching. The patches 1-8 should be applied first, then either waiting the next release or if the usb maintainer can provide us a stable tag, we can use it to merge the DT and bindings. Martin Blumenstingl (4): arm64: dts: amlogic: use the new USB control driver for GXL and GXM phy: amlogic: meson-gxl-usb3: remove code for non-existing PHY usb: dwc3: of-simple: remove Amlogic GXL and AXG compatibles dt-bindings: usb: dwc3: remove old DWC3 wrapper Neil Armstrong (9): dt-bindings: usb: amlogic,meson-g12a-usb-ctrl: add the Amlogic GXL and GXM Families USB Glue Bindings usb: dwc3: meson-g12a: specify phy names in soc data usb: dwc3: meson-g12a: handle the phy and glue registers separately usb: dwc3: meson-g12a: get the reset as shared usb: dwc3: meson-g12a: refactor usb2 phy init usb: dwc3: meson-g12a: refactor usb init usb: dwc3: meson-g12a: support the GXL/GXM DWC3 host phy disconnect usb: dwc3: meson-g12a: add support for GXL and GXM SoCs doc: dt: bindings: usb: dwc3: remove amlogic compatible entries .../bindings/phy/meson-gxl-usb3-phy.txt | 31 -- .../devicetree/bindings/usb/amlogic,dwc3.txt | 42 -- .../usb/amlogic,meson-g12a-usb-ctrl.yaml | 21 + .../devicetree/bindings/usb/dwc3.txt | 2 - .../dts/amlogic/meson-gx-libretech-pc.dtsi | 2 +- .../boot/dts/amlogic/meson-gx-p23x-q20x.dtsi | 2 +- .../amlogic/meson-gxl-s805x-libretech-ac.dts | 3 +- .../boot/dts/amlogic/meson-gxl-s805x-p241.dts | 3 +- .../amlogic/meson-gxl-s905d-phicomm-n1.dts | 4 + .../boot/dts/amlogic/meson-gxl-s905w-p281.dts | 4 + .../dts/amlogic/meson-gxl-s905w-tx3-mini.dts | 4 + .../amlogic/meson-gxl-s905x-khadas-vim.dts | 4 + .../amlogic/meson-gxl-s905x-libretech-cc.dts | 7 +- .../amlogic/meson-gxl-s905x-nexbox-a95x.dts | 3 +- .../dts/amlogic/meson-gxl-s905x-p212.dtsi | 7 +- arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 45 +- .../dts/amlogic/meson-gxm-khadas-vim2.dts | 3 +- .../boot/dts/amlogic/meson-gxm-nexbox-a1.dts | 3 +- .../boot/dts/amlogic/meson-gxm-vega-s96.dts | 4 + arch/arm64/boot/dts/amlogic/meson-gxm.dtsi | 7 +- drivers/phy/amlogic/Kconfig | 12 - drivers/phy/amlogic/Makefile | 1 - drivers/phy/amlogic/phy-meson-gxl-usb3.c | 283 ------------ drivers/usb/dwc3/dwc3-meson-g12a.c | 407 ++++++++++++++---- drivers/usb/dwc3/dwc3-of-simple.c | 30 +- 25 files changed, 421 insertions(+), 513 deletions(-) delete mode 100644 Documentation/devicetree/bindings/phy/meson-gxl-usb3-phy.txt delete mode 100644 Documentation/devicetree/bindings/usb/amlogic,dwc3.txt delete mode 100644 drivers/phy/amlogic/phy-meson-gxl-usb3.c -- 2.22.0