Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp4739654ybb; Tue, 24 Mar 2020 04:31:31 -0700 (PDT) X-Google-Smtp-Source: ADFU+vu5R7lDhIM5domm9B83nBAOsgqdLy2oZGU/AUR+4PMBAnWzcjjjPs0OToxlDwfKfeDnKkOR X-Received: by 2002:a9d:5a09:: with SMTP id v9mr20760859oth.214.1585049491607; Tue, 24 Mar 2020 04:31:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585049491; cv=none; d=google.com; s=arc-20160816; b=vjJ56Gd2FmJB5M78gH/xhQz9FmtaxyWxDpM0t0EX0h9Pa9xTIJs5WNdG8kF7SNSk8c 5B64Z6e7JiyyXzusNCePNWAjIG8qyG/dKG7x55O9DuC8GdseOOT8bNe/ZQlLvvJgdxFF pZb+JQDkX6VuwVDnGpvMQ9Bq17cFoMeK3X40Or4sInNgwPnfBcA/cDc6/C7K20j9JXCe N5WWHwr1znhPBbX+0xPNIGmgdZue7PqV89FH3zxksGnzCKQBa/c4q93d9whTTp2/awyK GBYEj/zUj9HsVdwesISCBzr9A3WYVGEAy2IWHkd2Dz+fMMkPJ2hIYl+b3QkAPdgMwo0R qEqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=09DFXumLUIbpAWD1lrtnJxD+VX0hptK1NU7JDfc3Te8=; b=tFsLv1Vh/Vw0F6rteZqAp2Om+oPJcbKktpfmIUxL/1FxvuNthTlEYpT0m+ThRpclc+ d6JouGyuQhwqPXs/Ilo3jGWyQIfWJfMjL/N0u26EWl7XUXT92kjMIlduHURVaQukT5yZ 7MUJZH90eHSFJi4991MvGtYEyI1qRXv0sQ499EAyJHhn/EmCZbM7eTB66jfuJumjfEKX hUfq7y67klmOlBR8RBduj1jnsdQAn/tBqY+LDQu0A6GaMDs6/cFx05j4gmbIrKa9W7Xo RvIONb1iKXiK6UF4uS7MLUAB/w+bYjPKsH/o/VlW2cI4WwxhPtsdSLxy1wgKTKH6HWLK sysQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CFfy9FIV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c24si9205890otf.33.2020.03.24.04.31.19; Tue, 24 Mar 2020 04:31:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CFfy9FIV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727334AbgCXL3t (ORCPT + 99 others); Tue, 24 Mar 2020 07:29:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:44992 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727217AbgCXL3t (ORCPT ); Tue, 24 Mar 2020 07:29:49 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 845DE2070A; Tue, 24 Mar 2020 11:29:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585049389; bh=U/4Civ8GXevpEjqpkUOuBd2G0WKgxBb5LGpN+uk3yS0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CFfy9FIVclzTIyDbBwcGXQchi4AFSmvDDBgLorsyDd7g10kuF/9DsjNYvUqMADYTy jA2iytrxOGzp70uED07Rx1HbLTL5F8RwG7MKYnehj2uE45ILASIanz0B1v+GbhIAsW sgqv3c4ICqqR84KwDGbREEemamGQDnIBSGQuF60s= Date: Tue, 24 Mar 2020 12:29:44 +0100 From: Greg Kroah-Hartman To: Eric Biggers Cc: Jiri Slaby , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, syzkaller-bugs@googlegroups.com, Eric Dumazet , Nicolas Pitre Subject: Re: [PATCH v3 0/2] vt: fix some vt_ioctl races Message-ID: <20200324112944.GA2276078@kroah.com> References: <20200320193424.GM851@sol.localdomain> <20200322034305.210082-1-ebiggers@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200322034305.210082-1-ebiggers@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 21, 2020 at 08:43:03PM -0700, Eric Biggers wrote: > Fix VT_DISALLOCATE freeing an in-use virtual console, and fix a > use-after-free in vt_in_use(). > > Changed since v2: > - Implemented tty_port_operations::destruct(). > - Added comments regarding vt_in_use() locking. > > Changed since v1: > - Made the vc_data be freed via tty_port refcounting. > - Added patch to fix a use-after-free in vt_in_use(). > > Eric Biggers (2): > vt: vt_ioctl: fix VT_DISALLOCATE freeing in-use virtual console > vt: vt_ioctl: fix use-after-free in vt_in_use() > > drivers/tty/vt/vt.c | 23 ++++++++++++++++++++++- > drivers/tty/vt/vt_ioctl.c | 28 ++++++++++++++++------------ > 2 files changed, 38 insertions(+), 13 deletions(-) Jiri, any objection to these? thanks, greg k-h