Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200324122023.9649-1-andriy.shevchenko@linux.intel.com> <20200324122023.9649-2-andriy.shevchenko@linux.intel.com>
In-Reply-To: <20200324122023.9649-2-andriy.shevchenko@linux.intel.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Tue, 24 Mar 2020 13:55:00 +0100
Message-ID: <CAJZ5v0jounauixe8jt1_z9zKmT5BdqhG6hvWREDDrP-VAUUNKQ@mail.gmail.com>
Subject: Re: [PATCH v2 2/3] driver core: Read atomic counter once in driver_probe_done()
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Linux PM <linux-pm@vger.kernel.org>,
        Ferry Toth <fntoth@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Mar 24, 2020 at 1:20 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Between printing the debug message and actual check atomic counter can be
> altered. For better debugging experience read atomic counter value only once.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Tested-by: Ferry Toth <fntoth@gmail.com>

Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

> ---
> v2: picked up tags
>  drivers/base/dd.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/base/dd.c b/drivers/base/dd.c
> index 43720beb5300..efd0e4c16ba5 100644
> --- a/drivers/base/dd.c
> +++ b/drivers/base/dd.c
> @@ -669,9 +669,10 @@ static int really_probe_debug(struct device *dev, struct device_driver *drv)
>   */
>  int driver_probe_done(void)
>  {
> -       pr_debug("%s: probe_count = %d\n", __func__,
> -                atomic_read(&probe_count));
> -       if (atomic_read(&probe_count))
> +       int local_probe_count = atomic_read(&probe_count);
> +
> +       pr_debug("%s: probe_count = %d\n", __func__, local_probe_count);
> +       if (local_probe_count)
>                 return -EBUSY;
>         return 0;
>  }
> --
> 2.25.1
>