Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp4895355ybb; Tue, 24 Mar 2020 07:18:10 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvp/dAMK6Hj1FRTi/MRIitNyBHC0K9QwqMsMoP9R46nK5E5Y59XZlK+m+LAbPkFN97PYjep X-Received: by 2002:aca:488a:: with SMTP id v132mr3640829oia.166.1585059490221; Tue, 24 Mar 2020 07:18:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585059490; cv=none; d=google.com; s=arc-20160816; b=FDBleZkBup72s/g9G5VsTY/B8F8eKs9KEP05Oca/kBX8L71NZTY97hKHczgqMTI6eh o834m2CycsxE3UeO+61gX3V/qYGMXfOj4NPNryXA10EcA+updkFGZmxBnZBzsCK/tcHx LK/Em0clZ9ZhpYQta8knGirsRFH+NZQC9L725WBwxod8fUaVpp3/LggLKSMoMUmMgUdo 8BxE9CQJj1k7MPCQUKyN7PKTA/Qz8BlLzbY9CNxUJ9SiVM0ad2lY6FdxIQN/lrIUCXOO cZf/kqEEYWk2qhcuVS+so12zXJa86m3Eqy6vycmudiFq8dgJtrHz6gVUKphNEAaS07gI aqEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:autocrypt:from:references:cc:to:subject :dkim-signature; bh=WrX2dN0WZf3CyQCjhLRoXWr/85ol3RhJkguU9XKSlBE=; b=tbP9QZuF+WyeVeTGX+XFdPdgDY1EIcuXgDHCXWyCINw41L59SxEh4CzbF/YcRDAoAQ 60JukGWdJaJe28eOH6JeQzUZJ5Cdysi2ejipCpYBl0Ebd3/eKq7pFC1qywyOvNnxEHW4 QHBbwG0A77ru3Fw7nFJQ5/TzXDE2bOjxo6WAzHZtWl/p7IOVVTZUahuHt17QwFxqelPc +Kx5oho7VPMPGT1oyaFz0W0mmDvqC+DeCbd52QJ7RBeUSINQoVXsxyUKL8+umk5ivOI3 WEqGDKIZsyri5aYB1h5JwfZqewpcgI/5xXn6yW0HBaCFG4Q/TAlFgLACYIEPF0lbyI+S osFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=TN9FBAA0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 64si4803038otn.173.2020.03.24.07.17.55; Tue, 24 Mar 2020 07:18:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=TN9FBAA0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727385AbgCXORY (ORCPT + 99 others); Tue, 24 Mar 2020 10:17:24 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:42372 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727282AbgCXORY (ORCPT ); Tue, 24 Mar 2020 10:17:24 -0400 Received: by mail-wr1-f66.google.com with SMTP id h15so9439550wrx.9 for ; Tue, 24 Mar 2020 07:17:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:autocrypt:organization:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WrX2dN0WZf3CyQCjhLRoXWr/85ol3RhJkguU9XKSlBE=; b=TN9FBAA0iUeEZbHU6oVkhWTWg5LIRl5igQtz+cOaDnDF3G1sdKkP9EoMrf9SUPQDNs nUm+B/gBHZAQriH4fECc/S18Q6f3B6GeXKBOD+JA0ryud+BwNIIFLPfhXm6Z2v9lZAiw +GGCb8sC8UmC489LPsaS9BDguP7qKUKTiqMANWuxS3BXSKDiNJPY+BPe2SFgdQnpGQRi IQZgURFnzeq8BEoD4bJM1BO0TU5LCQiMj5UKDKifd56DqZMyM80waZIPkjpXnCULAw57 eR7Gw5mj8Mv0oPV4Nj/X+uYow0DcNzp7aj0ge00oSzfs091nVDBXtT37Cf9XwPjgCdbp sw9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :organization:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=WrX2dN0WZf3CyQCjhLRoXWr/85ol3RhJkguU9XKSlBE=; b=W0u8AZaOwRJOL6THCBDVr4z6Oz6tluqeISKsSvWfrdhTAmqllDcuDHupOmJPis9763 aL7gTnjbNQ76MbettVOLJeOmxm+TVYFmlZobZ4rj6bewcNFJ1+L8+Qf7ARDck5V2X00x WC+ac2lKUbjXjA9i0XzNCBzVylS5B3jG3D+S+XmS1E8tl5WNPsqqtDHd2+qKxzJZ+hrC Mw6bJLnnON9A4YEBTCJo0RUM3mRyMR3PwFVu9AIX4IECDn+sxxvvo8LtnTMSXL+2X+OL 8O72sIo4YLGhXwI98oERbKe0P7GwyQKQLfSjQjEWKBR+8b4zFUYhehTr+AilNDxhr4E3 u5bA== X-Gm-Message-State: ANhLgQ15DcdUAgSxQqRmr6PH4fMFGDVJxY44pY+te1bZP3fWRXq8C+zk 63uo5IyrI2K1UcQzy/ecgPgA3Q== X-Received: by 2002:adf:f84d:: with SMTP id d13mr35399105wrq.186.1585059441357; Tue, 24 Mar 2020 07:17:21 -0700 (PDT) Received: from ?IPv6:2a01:e35:2ec0:82b0:5c5f:613e:f775:b6a2? ([2a01:e35:2ec0:82b0:5c5f:613e:f775:b6a2]) by smtp.gmail.com with ESMTPSA id d21sm28827482wrb.51.2020.03.24.07.17.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Mar 2020 07:17:20 -0700 (PDT) Subject: Re: [PATCH 02/13] usb: dwc3: meson-g12a: specify phy names in soc data To: Martin Blumenstingl Cc: kishon@ti.com, balbi@kernel.org, khilman@baylibre.com, linux-amlogic@lists.infradead.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Hanjie Lin References: <20200324102030.31000-1-narmstrong@baylibre.com> <20200324102030.31000-3-narmstrong@baylibre.com> From: Neil Armstrong Autocrypt: addr=narmstrong@baylibre.com; prefer-encrypt=mutual; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKE5laWwgQXJtc3Ryb25nIDxuYXJtc3Ryb25nQGJheWxpYnJlLmNvbT7CwHsEEwEKACUC GyMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheABQJXDO2CAhkBAAoJEBaat7Gkz/iubGIH/iyk RqvgB62oKOFlgOTYCMkYpm2aAOZZLf6VKHKc7DoVwuUkjHfIRXdslbrxi4pk5VKU6ZP9AKsN NtMZntB8WrBTtkAZfZbTF7850uwd3eU5cN/7N1Q6g0JQihE7w4GlIkEpQ8vwSg5W7hkx3yQ6 2YzrUZh/b7QThXbNZ7xOeSEms014QXazx8+txR7jrGF3dYxBsCkotO/8DNtZ1R+aUvRfpKg5 ZgABTC0LmAQnuUUf2PHcKFAHZo5KrdO+tyfL+LgTUXIXkK+tenkLsAJ0cagz1EZ5gntuheLD YJuzS4zN+1Asmb9kVKxhjSQOcIh6g2tw7vaYJgL/OzJtZi6JlIXOwU0EVid/pAEQAND7AFhr 5faf/EhDP9FSgYd/zgmb7JOpFPje3uw7jz9wFb28Cf0Y3CcncdElYoBNbRlesKvjQRL8mozV 9RN+IUMHdUx1akR/A4BPXNdL7StfzKWOCxZHVS+rIQ/fE3Qz/jRmT6t2ZkpplLxVBpdu95qJ YwSZjuwFXdC+A7MHtQXYi3UfCgKiflj4+/ITcKC6EF32KrmIRqamQwiRsDcUUKlAUjkCLcHL CQvNsDdm2cxdHxC32AVm3Je8VCsH7/qEPMQ+cEZk47HOR3+Ihfn1LEG5LfwsyWE8/JxsU2a1 q44LQM2lcK/0AKAL20XDd7ERH/FCBKkNVzi+svYJpyvCZCnWT0TRb72mT+XxLWNwfHTeGALE +1As4jIS72IglvbtONxc2OIid3tR5rX3k2V0iud0P7Hnz/JTdfvSpVj55ZurOl2XAXUpGbq5 XRk5CESFuLQV8oqCxgWAEgFyEapI4GwJsvfl/2Er8kLoucYO1Id4mz6N33+omPhaoXfHyLSy dxD+CzNJqN2GdavGtobdvv/2V0wukqj86iKF8toLG2/Fia3DxMaGUxqI7GMOuiGZjXPt/et/ qeOySghdQ7Sdpu6fWc8CJXV2mOV6DrSzc6ZVB4SmvdoruBHWWOR6YnMz01ShFE49pPucyU1h Av4jC62El3pdCrDOnWNFMYbbon3vABEBAAHCwn4EGAECAAkFAlYnf6QCGwICKQkQFpq3saTP +K7BXSAEGQECAAYFAlYnf6QACgkQd9zb2sjISdGToxAAkOjSfGxp0ulgHboUAtmxaU3viucV e2Hl1BVDtKSKmbIVZmEUvx9D06IijFaEzqtKD34LXD6fjl4HIyDZvwfeaZCbJbO10j3k7FJE QrBtpdVqkJxme/nYlGOVzcOiKIepNkwvnHVnuVDVPcXyj2wqtsU7VZDDX41z3X4xTQwY3SO1 9nRO+f+i4RmtJcITgregMa2PcB0LvrjJlWroI+KAKCzoTHzSTpCXMJ1U/dEqyc87bFBdc+DI k8mWkPxsccdbs4t+hH0NoE3Kal9xtAl56RCtO/KgBLAQ5M8oToJVatxAjO1SnRYVN1EaAwrR xkHdd97qw6nbg9BMcAoa2NMc0/9MeiaQfbgW6b0reIz/haHhXZ6oYSCl15Knkr4t1o3I2Bqr Mw623gdiTzotgtId8VfLB2Vsatj35OqIn5lVbi2ua6I0gkI6S7xJhqeyrfhDNgzTHdQVHB9/ 7jnM0ERXNy1Ket6aDWZWCvM59dTyu37g3VvYzGis8XzrX1oLBU/tTXqo1IFqqIAmvh7lI0Se gCrXz7UanxCwUbQBFjzGn6pooEHJYRLuVGLdBuoApl/I4dLqCZij2AGa4CFzrn9W0cwm3HCO lR43gFyz0dSkMwNUd195FrvfAz7Bjmmi19DnORKnQmlvGe/9xEEfr5zjey1N9+mt3//geDP6 clwKBkq0JggA+RTEAELzkgPYKJ3NutoStUAKZGiLOFMpHY6KpItbbHjF2ZKIU1whaRYkHpB2 uLQXOzZ0d7x60PUdhqG3VmFnzXSztA4vsnDKk7x2xw0pMSTKhMafpxaPQJf494/jGnwBHyi3 h3QGG1RjfhQ/OMTX/HKtAUB2ct3Q8/jBfF0hS5GzT6dYtj0Ci7+8LUsB2VoayhNXMnaBfh+Q pAhaFfRZWTjUFIV4MpDdFDame7PB50s73gF/pfQbjw5Wxtes/0FnqydfId95s+eej+17ldGp lMv1ok7K0H/WJSdr7UwDAHEYU++p4RRTJP6DHWXcByVlpNQ4SSAiivmWiwOt490+Ac7ATQRN WQbPAQgAvIoM384ZRFocFXPCOBir5m2J+96R2tI2XxMgMfyDXGJwFilBNs+fpttJlt2995A8 0JwPj8SFdm6FBcxygmxBBCc7i/BVQuY8aC0Z/w9Vzt3Eo561r6pSHr5JGHe8hwBQUcNPd/9l 2ynP57YTSE9XaGJK8gIuTXWo7pzIkTXfN40Wh5jeCCspj4jNsWiYhljjIbrEj300g8RUT2U0 FcEoiV7AjJWWQ5pi8lZJX6nmB0lc69Jw03V6mblgeZ/1oTZmOepkagwy2zLDXxihf0GowUif GphBDeP8elWBNK+ajl5rmpAMNRoKxpN/xR4NzBg62AjyIvigdywa1RehSTfccQARAQABwsBf BBgBAgAJBQJNWQbPAhsMAAoJEBaat7Gkz/iuteIH+wZuRDqK0ysAh+czshtG6JJlLW6eXJJR Vi7dIPpgFic2LcbkSlvB8E25Pcfz/+tW+04Urg4PxxFiTFdFCZO+prfd4Mge7/OvUcwoSub7 ZIPo8726ZF5/xXzajahoIu9/hZ4iywWPAHRvprXaim5E/vKjcTeBMJIqZtS4u/UK3EpAX59R XVxVpM8zJPbk535ELUr6I5HQXnihQm8l6rt9TNuf8p2WEDxc8bPAZHLjNyw9a/CdeB97m2Tr zR8QplXA5kogS4kLe/7/JmlDMO8Zgm9vKLHSUeesLOrjdZ59EcjldNNBszRZQgEhwaarfz46 BSwxi7g3Mu7u5kUByanqHyA= Organization: Baylibre Message-ID: Date: Tue, 24 Mar 2020 15:17:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/03/2020 15:13, Martin Blumenstingl wrote: > Hi Neil, > > On Tue, Mar 24, 2020 at 11:20 AM Neil Armstrong wrote: > [...] >> +static const char *meson_a1_phy_names[] = { >> + "usb2-phy0", "usb2-phy1" >> +}; > my understanding is that the A1 SoC only has usb2-phy1. > +Cc Hanjie Lin to confirm this I forgot a comment here, it only has a single PHY, but still the 2 U2 PHY controls slots... it would need a large amount of code to handle this tweak, and leaving 2 PHYs keeps the behavior before the patchset. Neil > > apart from that: > Reviewed-by: Martin Blumenstingl > > > Martin >