Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp4974294ybb; Tue, 24 Mar 2020 08:39:24 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuwy/wo7rxj34YemoWH91eedRRfW7fwsFwxtnehkWji6CQuroFODlGnXsudFtyCVZVR49Oq X-Received: by 2002:aca:aa81:: with SMTP id t123mr3902601oie.117.1585064363920; Tue, 24 Mar 2020 08:39:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585064363; cv=none; d=google.com; s=arc-20160816; b=bo9R9MZa5rqVv6s+5/F5/wS8qcSWJZNT0BHzTL+xgFFhn1K0onNdXUEnOaiBz2AonL P1+1FjKGde0VPHwGO83yHTB2n+52O41GMyqW/JAHmZojZb23kmEbAGKjCapeTtoi4J0A veVDopUWbvy+wpA66SmhaWHVIAbD0g+5wvWn2QoArbcPW38DGtO7UAQEwZaUjUpr+Ut1 Cauai76PI1n+yCYoGayYngBn58gB6KsH630a15yj5Yv9xn7xPwoeF4f20xbyLdNJIxjB akpHtqVQTiDG7wBZDY5hnlnHejWc3DM1LqBI25GPxkq9/2D6IU8nLR6Aqy8O4vN36HAw JDAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=++otbM3e7e3gQCd95V+euN8UkqMn+k2mD8zWvvvzKHM=; b=oymiCFUBNa/N7/zOyanXdhegx3yxylUdML4rC7CEVRdsZcYrdamJOKDEe0fIGB6hx2 Hz2K8+Ukkdp6ks+19RbetWEbYm00fnqGoqa+OSJeLiDbneXMvWO1AJV9PBXesbw3kHW8 WvYuft4WvU2rcDItDTlVq40yY5r+XaAiNZoHZoF0uCgt2CM6UAgm4wQPZyfqVwJ+AxGb 6SyF9IcF+DXxLYnoancp99wqquHB/WVHjufrRcrTzQwzRONqIGyZ0scQw+Y0X2A5fOV9 kupBBAqdnW+aHtXAN8hIUVWs7ocy9APoxbb6k/Cy6nVJEzPtBhjXDgQDvTYoCNXkYmjS fWkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=GrgxtSjO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o124si9113302oib.111.2020.03.24.08.39.11; Tue, 24 Mar 2020 08:39:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=GrgxtSjO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728553AbgCXPhU (ORCPT + 99 others); Tue, 24 Mar 2020 11:37:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:59912 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728461AbgCXPhL (ORCPT ); Tue, 24 Mar 2020 11:37:11 -0400 Received: from localhost.localdomain (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ABAE920788; Tue, 24 Mar 2020 15:37:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585064230; bh=kCyXQDXBIacIOUUlvhRJP7/5AucaMFFeuDD1X4ZYGzU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GrgxtSjO4ZBVgDGYO3uktGvMiyQriu3pRSakNzRBQWUfKNtpnF7oU0G8scgd12GVg A3FpQschv588Hn7cxGwCHRRLAkzViGpNxQzO0scK0UflIVu19AJaokpPr3RpHjk5aH ArP86APbCECHDZzC7+xj2K9YPxpHKirHDN8CeVkc= From: Will Deacon To: linux-kernel@vger.kernel.org Cc: Will Deacon , Eric Dumazet , Jann Horn , Kees Cook , Maddie Stone , Marco Elver , "Paul E . McKenney" , Peter Zijlstra , Thomas Gleixner , kernel-team@android.com, kernel-hardening@lists.openwall.com Subject: [RFC PATCH 08/21] Revert "list: Use WRITE_ONCE() when initializing list_head structures" Date: Tue, 24 Mar 2020 15:36:30 +0000 Message-Id: <20200324153643.15527-9-will@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200324153643.15527-1-will@kernel.org> References: <20200324153643.15527-1-will@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This reverts commit 2f073848c3cc8aff2655ab7c46d8c0de90cf4e50. There is no need to use WRITE_ONCE() to initialise a non-RCU 'list_head'. Cc: Paul E. McKenney Cc: Peter Zijlstra Signed-off-by: Will Deacon --- include/linux/list.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/list.h b/include/linux/list.h index c7331c259792..b86a3f9465d4 100644 --- a/include/linux/list.h +++ b/include/linux/list.h @@ -32,7 +32,7 @@ */ static inline void INIT_LIST_HEAD(struct list_head *list) { - WRITE_ONCE(list->next, list); + list->next = list; list->prev = list; } -- 2.20.1