Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 24 Mar 2020 16:39:50 +0000 (GMT)
From:   Alan Maguire <alan.maguire@oracle.com>
To:     Patricia Alfonso <trishalfonso@google.com>
cc:     davidgow@google.com, brendanhiggins@google.com,
        aryabinin@virtuozzo.com, dvyukov@google.com, mingo@redhat.com,
        peterz@infradead.org, juri.lelli@redhat.com,
        vincent.guittot@linaro.org, linux-kernel@vger.kernel.org,
        kasan-dev@googlegroups.com, kunit-dev@googlegroups.com,
        linux-kselftest@vger.kernel.org
Subject: Re: [RFC PATCH v2 1/3] Add KUnit Struct to Current Task
In-Reply-To: <20200319164227.87419-2-trishalfonso@google.com>
Message-ID: <alpine.LRH.2.21.2003241635230.30637@localhost>
References: <20200319164227.87419-1-trishalfonso@google.com> <20200319164227.87419-2-trishalfonso@google.com>
User-Agent: Alpine 2.21 (LRH 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On Thu, 19 Mar 2020, Patricia Alfonso wrote:

> In order to integrate debugging tools like KASAN into the KUnit
> framework, add KUnit struct to the current task to keep track of the
> current KUnit test.
> 
> Signed-off-by: Patricia Alfonso <trishalfonso@google.com>
> ---
>  include/linux/sched.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/linux/sched.h b/include/linux/sched.h
> index 04278493bf15..1fbfa0634776 100644
> --- a/include/linux/sched.h
> +++ b/include/linux/sched.h
> @@ -1180,6 +1180,10 @@ struct task_struct {
>  	unsigned int			kasan_depth;
>  #endif
>  
> +#if IS_BUILTIN(CONFIG_KUNIT)

This patch set looks great! You might have noticed I
refreshed the kunit resources stuff to incorporate
feedback from Brendan, but I don't think any API changes
were made that should have consequences for your code
(I'm building with your patches on top to make sure).
I'd suggest promoting from RFC to v3 on the next round
unless anyone objects.

As Dmitry suggested, the above could likely be changed to be
"#ifdef CONFIG_KUNIT" as kunit can be built as a
module also. More on this in patch 2..

> +	struct kunit			*kunit_test;
> +#endif /* IS_BUILTIN(CONFIG_KUNIT) */
> +
>  #ifdef CONFIG_FUNCTION_GRAPH_TRACER
>  	/* Index of current stored address in ret_stack: */
>  	int				curr_ret_stack;
> -- 
> 2.25.1.696.g5e7596f4ac-goog
> 
>